feat: persist configuration across terraform interrupts - #795
Open
zreigz wants to merge 3 commits into
Open
Conversation
zreigz
requested review from
floreks,
maciaszczykm and
michaeljguarino
as code owners
September 7, 2026 13:25
Contributor
Greptile SummaryThis PR persists app-domain prompt completion and deployment checkpoints so interrupted setup can resume without repeating completed work.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking hardening opportunity to make the newly frequent manifest writes atomic. The resume markers and checkpoint ordering are persisted and tested correctly, but an interruption during the direct manifest rewrite can still corrupt the state needed for resume. Files Needing Attention: pkg/up/deploy.go
|
| Filename | Overview |
|---|---|
| cmd/command/up/up.go | Skips completed app-domain configuration and immediately persists both selected domains and explicit skips. |
| cmd/command/up/up_test.go | Covers legacy configuration detection and YAML persistence of selected or skipped app domains. |
| pkg/manifest/types.go | Adds the app-domain completion marker to manifest YAML and JSON serialization. |
| pkg/up/deploy.go | Flushes every successful checkpoint immediately, but the underlying manifest rewrite is not atomic against interruption. |
| pkg/up/deploy_test.go | Verifies checkpoint advancement, persistence, failure behavior, and skipping of completed phases. |
Reviews (1): Last reviewed commit: "add comment" | Re-trigger Greptile
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip re-prompting on resume and flush deploy checkpoints immediately so a stop does not force the wizard to start over.
Labels
Test Plan
Checklist