fix(ChromaticAberration): coerce offset prop to Vector2#349
Open
yourlcfr wants to merge 1 commit into
Open
Conversation
The v3 rewrite reduced ChromaticAberration to a bare wrapEffect call, so an offset passed as a number or [x, y] tuple (which the prop types accept) is handed to ChromaticAberrationEffect's constructor as-is and stored directly into its Uniform. The effect then exposes a plain array, and the documented imperative pattern ref.current.offset.set(x, y) throws "offset.set is not a function". Route the prop through the existing useVector2 helper, mirroring Glitch. When no offset is passed, the effect's own default is left untouched. v2 had this coercion (pmndrs#224); it was lost in the v3 rewrite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #348.
Routes
offsetthrough the existinguseVector2helper before it reaches the effect constructor, mirroring whatGlitchalready does. Whenoffsetisn't passed, the effect's own defaultVector2(0.001, 0.0005)is left untouched.forwardRefwrapper around the existingwrapEffectcomponent, soblendFunction/opacityhandling is unchangedEffectComposer.test.tsx: tuple coercion (fails on master), default preservationvitest3 passed,eslintclean,yarn buildclean