Propagate cancellation token in async Merge - #880
Open
wxxb789 wants to merge 1 commit into
Open
Conversation
`Merge` created its enumerators and materialized the initial list without the token from `await foreach`, so cancellation was not observed by the source sequences. `Interleave` already plumbs the token this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mergeobtains its enumerators and materializes the initial list without the token coming fromawait foreach, so a cancellation is never observed by the source sequences.Interleavehad the same problem and was fixed in 8f587ac, this applies the same plumbing toMerge.The added test fails on
mainand passes with the fix.