Repository navigation
Include rowwiseDT as a default table-formatted call - #525
Merged
Merged
Conversation
Collaborator
|
It does look like it! Could you please add a test so that we keep an eye on that use case. |
Contributor
Author
|
Good call! The fact that the table 'header' uses missing arguments tripped up the original implementation, so it winds up being a bit more complicated. Tests and documentation updated. |
Collaborator
|
oh hmm I see. Does it mean trailing empty arguments should close the table formatting then? Could you add more tests for this case? |
Collaborator
|
Thanks! |
Contributor
Author
|
Thanks for tidying up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data.table::rowwiseDTis analogous totribble(), some examples:https://github.com/PsyTeachR/webexercises/blob/be725898ae910100e67d08577ca54e247d746f20/revdep/library/pema/data.table/doc/datatable-joins.R#L37-L44
https://github.com/jcprentice/epimodels/blob/f8cc8ec097360d9548a440ecd3db5ac25c9543a7/R/make_parameters.R#L327-L338
https://github.com/tdhock/2024-08-ift603-712/blob/30f257e435ca242cb65e74e486a1f05dd8bed294/cv-subsets-small-large-noise-fr.R#L187-L191