Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The test harness can hide failures, Node.js 18 is untested, and several output and documentation correctness issues remain.
Review effort: Balanced
Findings: 3
Open (4)
What changed in this PR
Modernizes project maintenance, testing, and documentation without changing the core API.
Changes:
- Migrates from pnpm, Tape, and ESLint to npm,
node:test, oxlint, and oxfmt. - Reorganizes automated tests and replaces the visual fixture with a standalone script.
- Refreshes package metadata, CI, documentation, and Node.js support.
| File | Description |
|---|---|
.editorconfig |
Removes legacy editor settings. |
.eslintignore |
Removes ESLint exclusions. |
.eslintrc |
Removes ESLint configuration. |
.gitattributes |
Enforces LF normalization. |
.github/workflows/test.yml |
Migrates CI to npm and a platform matrix. |
.node-version |
Selects Node.js 24. |
CHANGELOG.md |
Documents maintenance changes. |
README.md |
Refreshes badges, examples, and metadata. |
index.js |
Applies formatting changes. |
lib/formatter.js |
Reformats formatter implementation. |
lib/formatter.test.js |
Migrates formatter tests to node:test. |
lib/reporter.js |
Reformats reporter implementation. |
lib/reporter.test.js |
Migrates reporter tests to node:test. |
lib/util.js |
Reformats utility code. |
package-lock.json |
Adds npm dependency lockfile. |
package.json |
Updates tooling, scripts, metadata, and engines. |
pnpm-lock.yaml |
Removes pnpm lockfile. |
scripts/visual.js |
Adds standalone visual verification script. |
test/fixtures/forVisual.css |
Removes obsolete visual fixture. |
test/fixtures/less-bar.less |
Removes obsolete Less fixture. |
test/fixtures/less-foo.less |
Removes obsolete Less fixture. |
test/formatter.js |
Removes Tape formatter tests. |
test/index.js |
Removes legacy test entry point. |
test/lessIntegration.js |
Removes Less integration script. |
test/reporter.js |
Removes Tape reporter tests. |
test/visual.js |
Removes legacy visual script. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - 12 | ||
| name: Node.js ${{ matrix.node-version }} Quick | ||
| os: [ubuntu-latest, windows-latest] | ||
| node-version: [lts/*, latest] |
| const summaryColor = errorCount > 0 ? "red" : "yellow"; | ||
| const summarySymbol = errorCount > 0 ? util.errorSymbol : util.warningSymbol; | ||
| const summary = `${summarySymbol} ${messagesToLog.length} ${util.plur('problem', messagesToLog.length)} (${errorCount} ${util.plur('error')}, ${warningCount} ${util.plur('warning')})` | ||
| const summary = `${summarySymbol} ${messagesToLog.length} ${util.plur("problem", messagesToLog.length)} (${errorCount} ${util.plur("error")}, ${warningCount} ${util.plur("warning")})`; |
Comment on lines
+37
to
+38
| } catch (thrown) { | ||
| error = thrown; |
| By default, the messages are formatted for human legibility and sorted according to the line/column positions attached to the messages. But another formatting function can be passed in with an option, and sorting can be turned off with an option. | ||
|
|
||
| *By default, only warnings are logged*. If you would like to see more messages, you can change the `filter` function. | ||
| _By default, only warnings are logged_. If you would like to see more messages, you can change the `filter` function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.