Skip to content

Fix multi-days-feed - #86

Open
1aristotelis wants to merge 1 commit into
masterfrom
fix-multi-days
Open

1aristotelis wants to merge 1 commit into
masterfrom
fix-multi-days

Conversation

@1aristotelis

Copy link
Copy Markdown
Contributor

now should get the right amount of data into the multi day feed

now should get the right amount of data into the multi day feed
@1aristotelis
1aristotelis requested a review from stevenzeiler May 4, 2023 12:52
@stevenzeiler

Copy link
Copy Markdown
Contributor

I suspect this issue is deeper than this, and it also appears to me that your change will return only the first day of rankings.

@1aristotelis

1aristotelis commented May 4, 2023

Copy link
Copy Markdown
Contributor Author

Unless im mistaken getCachedMultiDayFeed() returns an array of array of rankings for the past 7 days.
the query returns rankings which should be the ranking of the past day (it is not) and days which is an array of rankings in the past other days.
I don't see why i would be wrong on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants