Bundle core extension on Android - #1096
Draft
simolus3 wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 482a2ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soon, we might not be able to publish the core extension to Maven Central anymore. To prepare for that eventuality, this migrates the react-native and capacitor packages to contain Android builds for the core extension in their npm package. These builds are then picked as jni sources directly instead of requiring a Gradle dependency.
The core extension download script for node lives in
tools/now and also covers downloading JNI dependencies for Android. We bundle them toandroid/core/jniLibs/<abi>/libpowersync.so, which is the same format the Gradle dependency had before. So apps continue to work without the Gradle dependency.I have tested
tools/powersynctestsanddemos/example-capacitoron Android.AI use: The new download script is mostly generated by Claude Code.