Conversation
simolus3
force-pushed
the
consistent-sync-options
branch
from
September 23, 2026 12:35
49de937 to
1afa4db
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the SDK is a bit inconsistent in how options are passed to the sync client:
userAgent,includeDefaultStreamsandcheckpointMode) are part of theSyncOptionsclass, passed via theoptionsparameter.crudThrottleMs,retryDelayMs,paramsandappMetadata) can only be passed as direct parameters toconnect().This deprecates individual parameters in favor of passing them all on
SyncOptions. The motivation is that we might get additionalconnect()methods in the future, for an upload-only or download-only connection. Having to duplicate all these parameters there is annoying for us and users, this moves them to a single place and reduces the amount of options onStreamingSyncClient.Additionally, this simplifies
BucketStorageto no longer be an interface/implementation pair: The only purpose of that interface was to be able to mock bucket storage implementations, but tests using a real database (and core extension) are more convincing anyway.