fix(postgres): skip replication-byte recorder in test-connection - #790
Open
Tyagiquamar wants to merge 1 commit into
Open
fix(postgres): skip replication-byte recorder in test-connection#790Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
TEST_CONNECTION does not register DATA_REPLICATED_BYTES, so installing the jpgwire recorder made the CLI fail before the connection check ran.
🦋 Changeset detectedLatest commit: 8a4224c The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-connectionruns inTEST_CONNECTIONmode, which never registers replication metrics.PostgresModulestill installed a jpgwire recorder that readsDATA_REPLICATED_BYTES, so the CLI failed withPSYNC_S0001before the connection check ran.TEST_CONNECTIONmode. Maintainer confirmed on Postgres test-connection fails because replication-byte metric is not registered #751 that metrics are not needed for this command.Fixes #751
Test plan
pnpm --filter @powersync/service-module-postgres exec vitest run test/src/metrics_recorder.test.ts(2 passed)test-connectionagainst a valid PostgreSQL replication config reports the connection result instead of the missing-counter error