Repository navigation
Optimize SalesHead_Has_PurchaseOrdreNo performance - #98
Open
PropmanProphecy with Copilot wants to merge 1 commit into
Open
PropmanProphecy with Copilot wants to merge 1 commit into
PropmanProphecy with Copilot wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot CLI created this pull request from a session on behalf of
PropmanProphecy
November 12, 2026 12:21
PropmanProphecy
marked this pull request as ready for review
November 13, 2026 10:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CPU profile showed
SalesHead_Has_PurchaseOrdreNoas a hotspot. It looped over every Sales Line of a header and ran a separateSELECT TOP 1on Purchase Line for each item line. The procedure is called per row from the Sales Order List, Quotes, Return Order List and Credit Memos pages (N+1 queries).Change
Replaced the loop with a single
IsEmpty()check on Purchase Line, using the existing key (Sales Order No.,Sales Order Line No.) filtered onSales Order No..Notes