Skip to content

test: fix npm stub on Windows - #248

Merged
angeloashmore merged 1 commit into
mainfrom
fix/windows-npm-stub
Aug 1, 2026
Merged

test: fix npm stub on Windows#248
angeloashmore merged 1 commit into
mainfrom
fix/windows-npm-stub

Conversation

@angeloashmore

@angeloashmore angeloashmore commented Jul 31, 2026

Copy link
Copy Markdown
Member

Resolves:

Description

Windows CI times out on the init and gen setup tests almost every run.

Reason: The npm stub in test/it.ts never worked on Windows: it is a POSIX shell script with a shebang (Windows only executes .exe/.cmd/.bat), and the stub directory was prepended to PATH with : instead of ;. Tests therefore ran the real npm install next@latest in a temp dir, which takes 30–180s on Windows runners and blows the 30s test timeout.

Solution: Add an npm.cmd stub next to the existing sh stub and use path.delimiter for the PATH prepend.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Check that the test windows jobs pass without the init/gen setup timeouts.

🤖 Generated with Claude Code

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@angeloashmore angeloashmore changed the title test: stub npm on Windows test: fix Windows runs by stubbing npm Jul 31, 2026
@angeloashmore angeloashmore changed the title test: fix Windows runs by stubbing npm test: fix npm stub on Windows Jul 31, 2026
@angeloashmore
angeloashmore marked this pull request as ready for review July 31, 2026 18:25
@angeloashmore
angeloashmore merged commit 5d594b1 into main Aug 1, 2026
14 checks passed
@angeloashmore
angeloashmore deleted the fix/windows-npm-stub branch August 1, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants