Skip to content

[scanner] fix: use valid brew tap trust commands - #978

Open
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-brew-tap-trust
Open

[scanner] fix: use valid brew tap trust commands#978
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
scanner/fix-brew-tap-trust

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Fix

Replace invalid brew tap --trust invocations with Homebrew 6.0-compatible brew tap followed by brew trust across ujust recipes and Bazaar hooks. Update brew lifecycle guidance so future recipes use the valid syntax.

Fixes #814


Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=scanner backend=copilot model=gpt-5.6-luna copilot=1.0.59

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergeable_state is dirty — this PR currently has a real merge conflict against main and needs a rebase before it can land. Separately, CI has not actually re-validated the current diff: only a single stale validate job ran (from before the repo split CI into test/build/validate jobs), so no unit test or build job has run against this code at all. Content itself (brew tap→trust split across system.just, apps.just, bazaar-hook, and skill docs) looks correct and consistent with Homebrew 6.0's requirements everywhere it touches — worth noting for the maintainer that sibling PR #1011 (also in this review pass) reintroduces the exact brew tap --trust bug this PR fixes, in the separate hooks.py file this PR doesn't touch.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Work is intentionally paused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew tap --trust is invalid syntax — breaks ujust devmode, installs on Homebrew 6.0+

1 participant