Repository navigation
fix: status dots stay round when a row's title wraps; release v0.12.1 - #75
Conversation
The DS .pl-dot is a shrinkable flex item, so beside a wrapping title it lost width and rendered as an oval. Pin flex:none in the board page until the design system carries it (protoContent#679). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head e454533ea974 · formal
No findings were raised, so there was nothing to verify. The PR is a minimal CSS fix (.pl-dot{flex:none} in the board view's PAGE string), a version bump to 0.12.1, and a regression test. The two protopatch nits both concern pre-existing issues (README dev instructions, a test gap in fetch_issues/fetch_prs) that this diff does not touch, and were correctly dispositioned out-of-scope. No coverage gaps — the changed surface is tiny and self-contained.
No findings — the review came back clean.
findings JSON (machine-readable)
[]Runner context: observed. Native parent-conversation exclusion and separate history exclusion are checked per execution. Intended prior findings may remain in the rendered prompt. Instruction-source observations describe the assembled system prompt; mandatory repository guidance remains applicable. External instruction sources and runtime additions remain unknown. Tool observations describe bound tools, inherited fence and enforcement; external policy remains unknown. Construction evidence does not establish semantic review coverage.
Raw finding accounting: incomplete
{"supported": true, "binding": {"attempt": "471de83da52f4950b238333e8561897f", "repo": "protoLabsAI/github-plugin", "head": "e454533ea9746a4edf94fccddd9744ea91225a31", "pr": "75"}, "raw": {"find_structural:d4cfc5ac9f264033fe799399:1": {"lane": "find_structural", "finding": {"file": "pyproject.toml", "line": 1, "severity": "nit", "category": "build-release", "claim": "README develop instructions use pip and bare commands while project is detected as uv-managed", "evidence": "The README's Develop section instructs contributors to run \u0060pip install -r requirements-dev.txt\u0060 and then bare \u0060ruff check . && ruff format --check . && pytest -q\u0060. The project is detected as using \u0060uv\u0060 as its package manager with commands like \u0060uv run ruff check .\u0060. A new contributor following the README would activate a pip-based virtualenv instead of the uv-managed one, potentially missing pinn Fix: Align the README develop instructions with the actual package manager. Either update to \u0060uv sync --dev && uv run ruff check . && uv run ruff format --check . && uv run pytest -q\u0060, or add a note clarif (protopatch confidence: low)", "source": "protopatch"}}, "find_structural:f51a3297ff07f14bd9995743:1": {"lane": "find_structural", "finding": {"file": "tests/test_counts_route.py", "line": 71, "severity": "nit", "category": "test-gap", "claim": "Missing non-JSON error path test for fetch_issues/fetch_prs", "evidence": "fetch_counts has an explicit test for run_gh returning (0, 'not JSON', '') asserting a parse error (test_counts_route.py:71-73). The equivalent fetch_issues and fetch_prs functions in test_board_view.py are tested for valid JSON and for non-zero exit codes, but never for a zero exit with unparseable stdout. If gh issue list ever returned 0 with garbage output, the route's behavior in that case is Fix: Add a test in test_board_view.py that patches ghplugin.api.run_gh to return (0, 'not json', '') and asserts the /issues and /prs routes return a structured error dict (not a 500). (protopatch confidence: medium)", "source": "protopatch"}}}, "lanes": {"find_correctness": {"state": "observed", "count": 0}, "find_removed_behavior": {"state": "observed", "count": 0}, "find_crossfile": {"state": "observed", "count": 0}, "find_conventions": {"state": "observed", "count": 0}, "find_structural": {"state": "observed", "count": 2}}, "gaps": ["verify: missing or malformed findings/accounting array"], "transitions": [{"stage": "synthesize", "raw_id": "find_structural:d4cfc5ac9f264033fe799399:1", "before": {"file": "pyproject.toml", "line": 1, "severity": "nit", "category": "build-release", "claim": "README develop instructions use pip and bare commands while project is detected as uv-managed", "evidence": "The README's Develop section instructs contributors to run \u0060pip install -r requirements-dev.txt\u0060 and then bare \u0060ruff check . && ruff format --check . && pytest -q\u0060. The project is detected as using \u0060uv\u0060 as its package manager with commands like \u0060uv run ruff check .\u0060. A new contributor following the README would activate a pip-based virtualenv instead of the uv-managed one, potentially missing pinn Fix: Align the README develop instructions with the actual package manager. Either update to \u0060uv sync --dev && uv run ruff check . && uv run ruff format --check . && uv run pytest -q\u0060, or add a note clarif (protopatch confidence: low)", "source": "protopatch"}, "after": {"raw_ids": ["find_structural:d4cfc5ac9f264033fe799399:1"], "disposition": "out-of-scope", "reason": "The finding concerns the README's develop instructions using pip instead of uv. This PR only bumps the version in pyproject.toml; it does not touch the README or its instructions. The inconsistency is pre-existing and not introduced or changed by this diff.", "evidence": "PR diff to pyproject.toml is a version string change (0.12.0 \u2192 0.12.1); no README file appears in the diff."}}, {"stage": "synthesize", "raw_id": "find_structural:f51a3297ff07f14bd9995743:1", "before": {"file": "tests/test_counts_route.py", "line": 71, "severity": "nit", "category": "test-gap", "claim": "Missing non-JSON error path test for fetch_issues/fetch_prs", "evidence": "fetch_counts has an explicit test for run_gh returning (0, 'not JSON', '') asserting a parse error (test_counts_route.py:71-73). The equivalent fetch_issues and fetch_prs functions in test_board_view.py are tested for valid JSON and for non-zero exit codes, but never for a zero exit with unparseable stdout. If gh issue list ever returned 0 with garbage output, the route's behavior in that case is Fix: Add a test in test_board_view.py that patches ghplugin.api.run_gh to return (0, 'not json', '') and asserts the /issues and /prs routes return a structured error dict (not a 500). (protopatch confidence: medium)", "source": "protopatch"}, "after": {"raw_ids": ["find_structural:f51a3297ff07f14bd9995743:1"], "disposition": "out-of-scope", "reason": "The finding identifies a missing test for a non-JSON error path in fetch_issues/fetch_prs. This PR does not modify those functions or their tests; it adds a CSS rule and a test for that rule. The test gap is pre-existing and not introduced by this diff.", "evidence": "PR diff adds test_status_dot_never_shrinks_in_a_flex_row to tests/test_board_view.py; no changes to fetch_issues, fetch_prs, or their existing tests."}}, {"stage": "verify", "raw_id": "find_structural:d4cfc5ac9f264033fe799399:1", "before": {"file": "pyproject.toml", "line": 1, "severity": "nit", "category": "build-release", "claim": "README develop instructions use pip and bare commands while project is detected as uv-managed", "evidence": "The README's Develop section instructs contributors to run \u0060pip install -r requirements-dev.txt\u0060 and then bare \u0060ruff check . && ruff format --check . && pytest -q\u0060. The project is detected as using \u0060uv\u0060 as its package manager with commands like \u0060uv run ruff check .\u0060. A new contributor following the README would activate a pip-based virtualenv instead of the uv-managed one, potentially missing pinn Fix: Align the README develop instructions with the actual package manager. Either update to \u0060uv sync --dev && uv run ruff check . && uv run ruff format --check . && uv run pytest -q\u0060, or add a note clarif (protopatch confidence: low)", "source": "protopatch"}, "after": {"raw_ids": ["find_structural:d4cfc5ac9f264033fe799399:1"], "disposition": "out-of-scope", "reason": "The finding concerns the README's develop instructions using pip instead of uv. This PR only bumps the version in pyproject.toml; it does not touch the README or its instructions. The inconsistency is pre-existing and not introduced or changed by this diff.", "evidence": "PR diff to pyproject.toml is a version string change (0.12.0 \u2192 0.12.1); no README file appears in the diff."}}, {"stage": "verify", "raw_id": "find_structural:f51a3297ff07f14bd9995743:1", "before": {"file": "tests/test_counts_route.py", "line": 71, "severity": "nit", "category": "test-gap", "claim": "Missing non-JSON error path test for fetch_issues/fetch_prs", "evidence": "fetch_counts has an explicit test for run_gh returning (0, 'not JSON', '') asserting a parse error (test_counts_route.py:71-73). The equivalent fetch_issues and fetch_prs functions in test_board_view.py are tested for valid JSON and for non-zero exit codes, but never for a zero exit with unparseable stdout. If gh issue list ever returned 0 with garbage output, the route's behavior in that case is Fix: Add a test in test_board_view.py that patches ghplugin.api.run_gh to return (0, 'not json', '') and asserts the /issues and /prs routes return a structured error dict (not a 500). (protopatch confidence: medium)", "source": "protopatch"}, "after": {"raw_ids": ["find_structural:f51a3297ff07f14bd9995743:1"], "disposition": "out-of-scope", "reason": "The finding identifies a missing test for a non-JSON error path in fetch_issues/fetch_prs. This PR does not modify those functions or their tests; it adds a CSS rule and a test for that rule. The test gap is pre-existing and not introduced by this diff.", "evidence": "PR diff adds test_status_dot_never_shrinks_in_a_flex_row to tests/test_board_view.py; no changes to fetch_issues, fetch_prs, or their existing tests."}}, {"stage": "report", "raw_id": "find_structural:d4cfc5ac9f264033fe799399:1", "before": {"file": "pyproject.toml", "line": 1, "severity": "nit", "category": "build-release", "claim": "README develop instructions use pip and bare commands while project is detected as uv-managed", "evidence": "The README's Develop section instructs contributors to run \u0060pip install -r requirements-dev.txt\u0060 and then bare \u0060ruff check . && ruff format --check . && pytest -q\u0060. The project is detected as using \u0060uv\u0060 as its package manager with commands like \u0060uv run ruff check .\u0060. A new contributor following the README would activate a pip-based virtualenv instead of the uv-managed one, potentially missing pinn Fix: Align the README develop instructions with the actual package manager. Either update to \u0060uv sync --dev && uv run ruff check . && uv run ruff format --check . && uv run pytest -q\u0060, or add a note clarif (protopatch confidence: low)", "source": "protopatch"}, "after": {"raw_ids": ["find_structural:d4cfc5ac9f264033fe799399:1"], "disposition": "out-of-scope", "reason": "The finding concerns the README's develop instructions using pip instead of uv. This PR only bumps the version in pyproject.toml; it does not touch the README or its instructions. The inconsistency is pre-existing and not introduced or changed by this diff.", "evidence": "PR diff to pyproject.toml is a version string change (0.12.0 \u2192 0.12.1); no README file appears in the diff."}}, {"stage": "report", "raw_id": "find_structural:f51a3297ff07f14bd9995743:1", "before": {"file": "tests/test_counts_route.py", "line": 71, "severity": "nit", "category": "test-gap", "claim": "Missing non-JSON error path test for fetch_issues/fetch_prs", "evidence": "fetch_counts has an explicit test for run_gh returning (0, 'not JSON', '') asserting a parse error (test_counts_route.py:71-73). The equivalent fetch_issues and fetch_prs functions in test_board_view.py are tested for valid JSON and for non-zero exit codes, but never for a zero exit with unparseable stdout. If gh issue list ever returned 0 with garbage output, the route's behavior in that case is Fix: Add a test in test_board_view.py that patches ghplugin.api.run_gh to return (0, 'not json', '') and asserts the /issues and /prs routes return a structured error dict (not a 500). (protopatch confidence: medium)", "source": "protopatch"}, "after": {"raw_ids": ["find_structural:f51a3297ff07f14bd9995743:1"], "disposition": "out-of-scope", "reason": "The finding identifies a missing test for a non-JSON error path in fetch_issues/fetch_prs. This PR does not modify those functions or their tests; it adds a CSS rule and a test for that rule. The test gap is pre-existing and not introduced by this diff.", "evidence": "PR diff adds test_status_dot_never_shrinks_in_a_flex_row to tests/test_board_view.py; no changes to fetch_issues, fetch_prs, or their existing tests."}}], "complete": false, "losses": [], "report_findings": []}
Problem
In the GitHub view, the status dot on an issue or PR row renders as a tall oval whenever the row's title wraps. At narrow panel widths that is every row.
Cause
Each row's top line is a flex row holding the dot and the title (
.row .top{display:flex}). The design system's.pl-dotis 8px by 8px but still shrinkable, so when the title is wider than the row the browser shrinks the dot's width and leaves its height.Fix
view.py:.pl-dot{flex:none}in the board page styles. It covers the list rows and the Checks tab rows.Testing
test_status_dot_never_shrinks_in_a_flex_row; it fails without theview.pychange.ruff check .,ruff format --check .andpytest -qpass locally (594 passed).🤖 Generated with Claude Code