Skip to content

fix: one GitHub view, not two; release v0.12.2 - #76

Merged
mabry1985 merged 1 commit into
mainfrom
fix/one-github-view
Nov 17, 2026
Merged

mabry1985 merged 1 commit into
mainfrom
fix/one-github-view

Conversation

@mabry1985

Copy link
Copy Markdown
Member

The manifest declared two views of the same read-only board: github-workspace (placement: rail) and github (placement: right). Both were labelled GitHub with the same icon, so every agent with the plugin showed two identical GitHub icons, and ⌘K listed two GitHub entries. Views can be dragged to any dock, so placement never needed a second view.

  • Remove the github-workspace view, its /plugins/github/workspace public path and the /workspace route.
  • Keep github: right dock by default, still palette: inline. Saved console layouts drop the removed key on their own (reconcilePluginViews).
  • Bump to 0.12.2 (manifest, pyproject, uv.lock). Replace the workspace test with a one-board-view guard.

Gate: ruff check, ruff format --check, pytest (594 passed).

🤖 Generated with Claude Code

The plugin declared two views of the same read-only board — github-workspace
(placement: rail) and github (placement: right) — both labelled GitHub with the
Github icon. Views are drag-movable across every dock, so placement never needed
a second view; it only rendered a duplicate GitHub icon on every agent.

Drop github-workspace (manifest view, public path, /workspace route). Keep github
(right dock by default, palette: inline). Persisted layouts prune the gone key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — WARN

code-review-structural · head 1a41a500ad7d · formal

Clean removal PR with one minor defect: a stale docstring in view.py:7 that still references the now-removed "full-width rail view." Three independent lanes flagged it; the verifier confirmed it against the file at head. The structural engine's 10 findings all target pre-existing code untouched by this diff and were correctly dispositioned out-of-scope. No blockers, no majors, no panel disagreement. Fix-first: update line 7 of view.py's docstring to drop the rail-view claim.

Findings

Severity Location Finding Verified
🟡 minor view.py:7 The view.py module docstring still claims the board is declared 'plus a full-width rail view' in the manifest, but the PR removes the github-workspace rail vie… confirmed
findings JSON (machine-readable)
[
  {
    "file": "view.py",
    "line": 7,
    "severity": "minor",
    "category": "cross-file",
    "claim": "The view.py module docstring still claims the board is declared 'plus a full-width rail view' in the manifest, but the PR removes the github-workspace rail view from protoagent.plugin.yaml, making the docstring factually incorrect. Flagged by both conventions and cross-file review.",
    "evidence": "view.py:7: 'right-dock view AND a \u2318K palette morph (``palette: inline``), plus a full-width rail view.' \u2014 but protoagent.plugin.yaml now only has: '- { id: github, label: GitHub, icon: Github, path: /plugins/github/view, placement: right, palette: inline }' with no rail view.",
    "raw_ids": [
      "find_conventions:2b7efc7cb0b45372143ec9a2:1",
      "find_crossfile:90a845d7966966ba214df96e:1",
      "find_removed_behavior:f5feccd7e42d33ff3f05f292:1"
    ],
    "accounting_reason": "Merged three findings (conventions: minor, cross-file: minor, removed-behavior: nit) on the same file/line describing the same stale docstring. Kept minor severity (2 of 3 agreed), cross-file category (inconsistency between view.py and manifest), and the cross-file finder's evidence as it shows both sides of the contradiction.",
    "verdict": "confirmed",
    "note": "Read view.py at head: line 7 is verbatim 'right-dock view AND a \u2318K palette morph (``palette: inline``), plus a full-width rail view.' The diff shows the PR updated line 4 (removing 'and ``/workspace``') but left line 7 untouched. The manifest at head has no rail-placement view (github-workspace removed). The docstring is stale."
  }
]

Runner context: observed. Native parent-conversation exclusion and separate history exclusion are checked per execution. Intended prior findings may remain in the rendered prompt. Instruction-source observations describe the assembled system prompt; mandatory repository guidance remains applicable. External instruction sources and runtime additions remain unknown. Tool observations describe bound tools, inherited fence and enforcement; external policy remains unknown. Construction evidence does not establish semantic review coverage.

Raw finding accounting: complete. Raw findings: 13; gaps: 0. Full trace omitted from this review to fit GitHub's body limit.

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the WARN verdict for head 1a41a500ad7d: all checks terminal-green, zero unresolved review threads. (approve-on-green)

Open findings carried by this approval — non-blocking, but they did not go away:

  • minor view.py:7 — The view.py module docstring still claims the board is declared 'plus a full-width rail view' in the manifest, but the PR removes the github-workspace rail view from protoagent.plugin.yaml, making the

Approving a WARN does not resolve its findings (issue #22).

@mabry1985
mabry1985 merged commit 961f199 into main Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant