Skip to content

ci: run on GitHub-hosted runners; drop the Namespace profile - #13

Open
mabry1985 wants to merge 1 commit into
mainfrom
chore/github-hosted-runners
Open

mabry1985 wants to merge 1 commit into
mainfrom
chore/github-hosted-runners

Conversation

@mabry1985

Copy link
Copy Markdown
Member

The org no longer uses Namespace runners. Jobs that named namespace-profile-protolabs-linux now run on ubuntu-latest, and comments that described moving desktop legs onto Namespace profiles now describe the GitHub-hosted setup (matching protoAgent protoLabsAI#5070, including the macos-15 default now that macos-14 is retired).

🤖 Generated with Claude Code

The org no longer uses Namespace runners.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — WARN

code-review-structural · head 42e53bd8895d · formal

Low-risk PR: a runner-label bump (macos-14 → macos-15) and a comment rewrite in desktop-build.yml. Verification confirmed both findings against head. The one thing to fix before merge is the stale os: macos-14 matrix label that now contradicts the actual runner. The panel also flagged a docs inconsistency in releasing.md that still references the removed Namespace-profile rationale. No panel disagreement on severity; all findings are minor. No gaps — the verifier covered all 2 findings.

Findings

Severity Location Finding Verified
🟡 minor .github/workflows/desktop-build.yml:79 The matrix os label for the macOS leg still reads macos-14 while the runs-on default was changed to macos-15, leaving a stale label that contradicts th… confirmed
🟡 minor docs/guides/releasing.md:57 The PR removes the Namespace-profile rationale from desktop-build.yml, but releasing.md still tells operators to point DESKTOP_*_RUNNER at a Namespace profile … confirmed
findings JSON (machine-readable)
[
  {
    "file": ".github/workflows/desktop-build.yml",
    "line": 79,
    "severity": "minor",
    "category": "cross-file",
    "claim": "The matrix `os` label for the macOS leg still reads `macos-14` while the `runs-on` default was changed to `macos-15`, leaving a stale label that contradicts the actual runner (flagged by both cross-file and conventions review).",
    "evidence": "- os: macos-14          # Apple Silicon runner\n            target: aarch64-apple-darwin",
    "verdict": "confirmed",
    "note": "Read file at head: matrix include has `os: macos-14` (line ~79) while the runs-on expression (changed by this PR) defaults to `'macos-15'`. The diff shows the runs-on line was updated but the matrix label was not."
  },
  {
    "file": "docs/guides/releasing.md",
    "line": 57,
    "severity": "minor",
    "category": "removed-behavior",
    "claim": "The PR removes the Namespace-profile rationale from desktop-build.yml, but releasing.md still tells operators to point DESKTOP_*_RUNNER at a Namespace profile and says defaults keep the current hosted runners; the docs now contradict the workflow.",
    "evidence": "> **Runner cost.** Every other workflow runs on Namespace; the desktop matrix is\n> the only GitHub-hosted usage (macOS bills at 10\u00d7, Windows 2\u00d7). To move a leg onto\n> a Namespace profile once the org provisions one, set the repo variable",
    "verdict": "confirmed",
    "note": "Read releasing.md at head: the blockquote still says 'Every other workflow runs on Namespace' and 'To move a leg onto a Namespace profile once the org provisions one'. The PR diff only modifies desktop-build.yml; releasing.md is untouched, so the docs still describe the removed Namespace-profile pattern."
  }
]

1 finding(s) excluded from the verdict by in-diff confinement (file not among this PR's changed paths):

  • docs/guides/releasing.md (minor) — The PR removes the Namespace-profile rationale from desktop-build.yml, but releasing.md still tells operators to point DESKTOP_*_RUNNER at a Namespace profile a

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant