Repository navigation
feat: Review gate: match a recurring finding across rounds by claim similarity, not exact file+claim (#727) - #787
Merged
mabry1985 merged 1 commit intoNov 18, 2026
Conversation
…imilarity, not exact file+claim (#727)
There was a problem hiding this comment.
QA panel review — PASS
reviewer-of-record · head 12868a3da100 · formal
Reviewer of record: project board. This PR is labelled reviewer-of-record:board, so its review belongs to that reviewer, and its board/review-gate status is success at 12868a3da100 (“Review gate clean — 2 finding(s), none blocking”). This PASS carries that verdict into the gates that read this panel's; no panel ran on this head. Comment @vera review for an independent review.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
mabry1985
deleted the
feat/bd-8ndhb-review-gate-match-a-recurring-finding-ac
branch
November 18, 2026 03:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A review finding that comes back re-worded, or reported in another file, is now recognised as the same finding, so the budget block reads "persist" instead of "needs a design call" (#727). The targeted suites pass: the new
tests/test_review_identity_727.py, both #514 files andtests/test_block_pages_735.py; I did not run the full suite.loop/reconcile.py): an exact_finding_identityrepeat still matches first. Otherwise the claims are compared by Jaccard overlap of their word tokens (case-folded, stop-words dropped, plain inflection suffix stripped). The file is never required to match; it only breaks a tie between equally similar earlier claims._CLAIM_SIMILARITY_THRESHOLD = 0.33, no config. On the bd-j5qr2 rounds, the re-worded pair (rounds 3 and 4) scores 0.42. Round 1 against round 4, a different defect on the same card, scores 0.14; the round-1 claim is my reconstruction from the issue's abridged table._CLAIM_SIMILARITY_MIN_SHARED = 3. Without it, very short claims such as "bug A" / "bug B" overlap by half on one shared word and would match. Short claims therefore match by exact identity only, as before._REVIEW_GATE_BLOCK_MARKERSstill classes both. A finding matched by similarity gets a suffix in the reason and PR comment, e.g.[re-worded since round 1, was loop/drive.py:2518], so the operator can check the two wordings really are one defect. Exact repeats are named exactly as before.review_fix_maxand its config are untouched; the card still blocks on the same round.changelog.d/727.md. The task said no CHANGELOG, but recent commits each add a fragment there, so I followed that convention; drop it if it is unwanted.Fixes #727