Repository navigation
feat: Environment preparation: ignore a cache-only node_modules the package manager doesn't manage (#785) - #788
Merged
mabry1985 merged 1 commit intoNov 18, 2026
Conversation
…ackage manager doesn't manage (#785)
There was a problem hiding this comment.
QA panel review — PASS
reviewer-of-record · head 9b1c9a00ad9d · formal
Reviewer of record: project board. This PR is labelled reviewer-of-record:board, so its review belongs to that reviewer, and its board/review-gate status is success at 9b1c9a00ad9d (“Review gate clean — 0 finding(s), none blocking”). This PASS carries that verdict into the gates that read this panel's; no panel ran on this head. Comment @vera review for an independent review.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
mabry1985
deleted the
feat/bd-rb6zb-environment-preparation-ignore-a-cache-o
branch
November 18, 2026 03:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A cache-only
node_modulesno longer counts as an installed environment, so it can't fail restore with "setup_cmd did not recreate environments" (#785). The three targeted test files pass (44 tests); the full suite was not run.worktree.py, new_stray_node_modules): anode_modulesis skipped when it is a real directory holding only hidden entries, with no package-manager state inside and nopackage.jsonbeside it. It is logged once per directory at info and never quarantined or deleted._installed_environments(so promotion markers stop naming strays) and the pending marker read back inrestore_worktree_environment(so an old marker naming a stray no longer blocks).node_moduleswithout.modules.yaml,.package-lock.json,.yarn-state.yml,.yarn-integrityor a siblingpackage.json. Taken literally, that breaks existing tests intests/test_promoted_worktree_environment.pyandtests/test_environment_restore_737.py, which require an empty or package-holdingnode_moduleswith nopackage.jsonto stay an environment. So a directory is ignored only when it is positively cache-shaped; these still count as environments:.binor.pnpm.tests/test_environment_stray_node_modules_785.py, new):package.jsonroot case are still reported and still required aftersetup_cmd.changelog.d/785.md. The card says there is no CHANGELOG, but recent commits each add a fragment there, so I added one; drop it if unwanted.ruff format .left all 237 files unchanged. No existing behaviour was removed.Fixes #785