Repository navigation
feat: Needs-you: one "merge is yours" item per card, updated on re-review and retired when the PR merges or closes (#786) - #789
Merged
mabry1985 merged 1 commit intoNov 18, 2026
Conversation
…view and retired when the PR merges or closes (#786)
There was a problem hiding this comment.
QA panel review — PASS
reviewer-of-record · head 2b43bc4fa902 · formal
Reviewer of record: project board. This PR is labelled reviewer-of-record:board, so its review belongs to that reviewer, and its board/review-gate status is success at 2b43bc4fa902 (“Review gate clean — 2 finding(s), none blocking”). This PASS carries that verdict into the gates that read this panel's; no panel ran on this head. Comment @vera review for an independent review.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
mabry1985
deleted the
feat/bd-g8fne-needs-you-one-merge-is-yours-item-per-ca
branch
November 18, 2026 03:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A human-merge card now has one pending "merge is yours" item, naming the latest head, and the item is retired when the PR merges or closes (#786).
_queue_agent_page(loop/reconcile.py) keys the pagepanel-verdict:<fid>; the head stays in the text.panel-verdict:<fid>:<head>rows.src/inbox/store.py,list()returns only rows withdelivered_at IS NULLby default andmark_deliveredsets it. That is the same seam block pages already use, so no host change is needed. I did not trace the console's Needs-you query itself beyond theneeds_humanflag on those rows.Three additions beyond the brief, for review to judge:
block_pages.sweepnow also retires panel-verdict items whose card isdone, or blocked with the "PR closed without merging" reason. This clears the items already sitting in live inboxes for PRs that merged before this change, and retries a retirement that failed at the edge. It reuses the inbox read the sweep already makes.Unlisted file changed:
block_pages.py, the host-inbox lifecycle module. It holds the new helpers (verdict_key,verdict_card_id,retire_verdict_pages,verdict_settled), the sweep extension, and a sharedPR_CLOSED_REASONconstant that the CLOSED edge now uses for its unchanged block reason. No behaviour was removed.Tests:
tests/test_panel_verdict_wake.py(38 pass) now pins the per-card key and covers:I ran targeted tests only: the neighbouring inbox and reconcile tests pass, and the full suite was left to the board's gate.
ruff format .left the rest of the repo unchanged.Fixes #786