Repository navigation
fix(ci): release page before npm, surface the OIDC trust failure, re-publish an existing tag - #67
Merged
Merged
Conversation
…h an existing tag v2.6.0's run tagged and moved v2, then died at npm publish with ENEEDAUTH, so no GitHub release page was ever created (it came after npm). - Create the GitHub release before npm publish: consumers resolve @v2 from git, so an npm failure must not leave a tag without a release page. - On npm failure, print the OIDC lines from npm's debug log. A failed token exchange is logged only at verbose level, which is why the run showed only a bare ENEEDAUTH. - Document the exact, case-sensitive trusted-publisher grant. The old comment recorded it as 'protolabsai', the casing that broke protoPatch's publishing. - workflow_dispatch takes an optional ref, so an existing tag can be re-published byte-for-byte from the fixed workflow on main. - The major alias only moves forward, so re-publishing an old tag can't drag @v2 back. - npm pkg fix: bin paths without ./ and git+ repository url (silences the 'script name was invalid and removed' warnings on every publish). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head 723ae4773058 · formal
Clean pass. The panel raised no findings across all four LLM lanes (correctness, removed-behavior, cross-file, conventions) and the protoPatch engine's four items were all pre-existing conditions outside this diff's scope. The verifier confirmed nothing-to-verify. No prior requests to disposition. No coverage gaps: release.yml was read in full by every LLM finder and all cross-file contracts were checked.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v2.6.0's release run tagged and moved
v2, then died atnpm publishwith a bareENEEDAUTH. The GitHub release step came after npm, so v2.6.0 never got a release page (closes the open half of #62's diagnosis).Root cause, confirmed
A diagnostic dispatch of this branch (
ref=v2.6.0, run 38214072665) printed the OIDC lines from npm's debug log:So npm does attempt the OIDC exchange, and npmjs.com rejects it. npm masks a trusted-publisher mismatch as "package not found" and logs it only at verbose level, so the publish surfaces as
ENEEDAUTH. The old workflow comment recorded the grant asprotolabsai / release-tools / release.yml. That lowercase org is the case-sensitive mismatch that broke protoPatch's publishing in September. GitHub's OIDC claim carriesprotoLabsAI.This needs a maintainer on npmjs.com; no workflow change can fix it. Go to npmjs.com/package/@protolabsai/release-tools/access → Trusted publishing, delete the grant, and re-create it as
protoLabsAI/release-tools/release.yml, with no environment and "allow publishing directly" ticked. The fields are immutable, so it has to be deleted and re-created. Then rungh workflow run Release -R protoLabsAI/release-tools -f ref=v2.6.0.Changes
@v2from git, so an npm failure no longer leaves a tag with no release page. The diagnostic run already created the v2.6.0 release.workflow_dispatchinputref: re-publishes an existing tag byte-for-byte using the fixed workflow file from main.backfill, so it doesn't takelatestfrom a newer version.@v2back.npm pkg fix: removes the./from bin paths and addsgit+to the repository url. This silences the misleading "script name … was invalid and removed" warnings; npm was normalizing those entries, not dropping them.🤖 Generated with Claude Code