Repository navigation
chore: release v2.7.1 — pin diff names a move to the built-in as such - #69
Merged
Merged
Conversation
product-archetype v0.2.1's generated Member pins said 'artifact v0.11.1 -> unpinned' when the member became 'builtin: true'. The diff compared refs only; it now compares what the member resolves to (tag, built-in, or unpinned). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head fa5f8701c41d · formal
No findings were raised, so there was nothing to verify. All four LLM finders independently confirmed the core change (comparing pinLabel results instead of raw refs in diffBundlePins) is correct, with no removed behavior, cross-file issues, or convention violations. The single tool-sourced finding (protoPatch on a package.json test-script glob) was dropped as it targets pre-existing code the diff does not touch. No coverage gaps: lib/bundle-pins.mjs and its test were reviewed by every lane.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release 2.7.1. Follow-up to #68, found on the first real archetype run.
product-archetype v0.2.1's generated Member pins section said:
The member had become
{ id: artifact, builtin: true }.diffBundlePinscomparedrefonly, so a move from a tag to the built-in read as the tag going missing. It now compares what the member resolves to (a release tag,built-in, orunpinned), so the line readsv0.11.1 → built-in. A builtin-to-builtin manifest still shows no change.I already corrected the published v0.2.1 body with
gh release edit.npm test: 94 pass, including a new test for this case.biome lintis clean.🤖 Generated with Claude Code