Skip to content

chore: release v2.7.1 — pin diff names a move to the built-in as such - #69

Merged
mabry1985 merged 1 commit into
mainfrom
fix/pin-diff-builtin
Oct 12, 2026
Merged

mabry1985 merged 1 commit into
mainfrom
fix/pin-diff-builtin

Conversation

@mabry1985

Copy link
Copy Markdown
Member

Patch release 2.7.1. Follow-up to #68, found on the first real archetype run.

product-archetype v0.2.1's generated Member pins section said:

- `artifact` v0.11.1 → unpinned

The member had become { id: artifact, builtin: true }. diffBundlePins compared ref only, so a move from a tag to the built-in read as the tag going missing. It now compares what the member resolves to (a release tag, built-in, or unpinned), so the line reads v0.11.1 → built-in. A builtin-to-builtin manifest still shows no change.

I already corrected the published v0.2.1 body with gh release edit.

npm test: 94 pass, including a new test for this case. biome lint is clean.

🤖 Generated with Claude Code

product-archetype v0.2.1's generated Member pins said 'artifact v0.11.1 ->
unpinned' when the member became 'builtin: true'. The diff compared refs only;
it now compares what the member resolves to (tag, built-in, or unpinned).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — PASS

code-review-structural · head fa5f8701c41d · formal

No findings were raised, so there was nothing to verify. All four LLM finders independently confirmed the core change (comparing pinLabel results instead of raw refs in diffBundlePins) is correct, with no removed behavior, cross-file issues, or convention violations. The single tool-sourced finding (protoPatch on a package.json test-script glob) was dropped as it targets pre-existing code the diff does not touch. No coverage gaps: lib/bundle-pins.mjs and its test were reviewed by every lane.

No findings — the review came back clean.

findings JSON (machine-readable)
[]

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the PASS verdict for head fa5f8701c41d: all checks terminal-green, zero unresolved review threads. (approve-on-green)

@mabry1985
mabry1985 merged commit 9a050ed into main Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant