Skip to content

Read a Copilot Finding Named Only in the Overview File Table in pr_review.py #2982

Closed

Description

@ptr727

Context

The first Copilot round on the #2980 promotion, at head 4a0370f, used the ccr-overview-v2 body. It carried three findings where the digest counted two, and nothing in the digest marked the third:

  • The headline reads "Three unresolved findings remain, including one critical guard bypass risk."
  • The open-findings block reads "2 open findings", and lists the two that have threads.
  • The file table's gh-write-guard.py row reads "Critical finding (2 votes): traverse commands executed by eval. Moderate finding (1 vote): preserve the terminal-option exception after redirections."

The second finding in that row has no thread and no entry in the open-findings block. pr_review.py wait printed overview=2/2 and shapes=ok, and no FINDINGS WITH NO THREAD block, so the digest read the round as fully threaded. The finding was caught only by reading the review body.

What to Change

Read the file table's <Severity> finding (N votes): <title> annotations, and the headline's spelled-out count, as findings the round raised. Report any annotation that matches no open-findings entry under FINDINGS WITH NO THREAD, and let a headline count above the open-findings count leave Merge Gate item 3 unsatisfied the way a T above the thread count already does.

Activity

  1. added a commit that references this issue on Oct 14, 2026
    3833ab8
  2. added a commit that references this issue on Oct 14, 2026
    8269978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    scriptA defect in hub tooling

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions