[ptr727]

Summary

host-setup/agent-safety/claude/install.py registered three hooks: gh-write-guard and model-tier-guard under PreToolUse, and the stray-process sweep under SessionEnd. It carried a separate copy of the registration logic for each, so a later fix to that logic had to be made in every copy.

• register_hook is a new module-level helper. It strips every entry naming a hook from an event's groups, then registers that hook once in the group a selector picks, or in a new group carrying the given matcher. main now calls it for all three hooks.
• registration_problems now checks both PreToolUse hooks through one nested check_pre_tool_hook, which takes the hook's name, the tools its matcher must see, and the wording of its messages.

This is a pure refactor. Every message string, its order, and its deduplication are unchanged, and so is every settings.json shape the installer writes. That includes the SessionEnd group, which is still created with no matcher key.

The comments label is set because the counting comment moved into the shared helper (re-indented and reworded for both hooks), and the tool-coverage comment now covers one tool or several.

Verification

• python3 -m unittest discover -s host-setup/agent-safety/claude -p 'test_*.py': 184 tests, OK
• uvx ruff@latest check and format --check on host-setup/agent-safety/claude: clean
• uvx mypy host-setup/agent-safety/claude/install.py: no issues
• Local strict review (frontier tier), two passes. The first raised one wording finding on the moved comment, fixed in 208d4a7, and the second pass raised none.

Pre-existing findings, filed

• host-setup/agent-safety/claude/install.py, the SessionEnd check loop in registration_problems, design. It still hand-rolls the count loop that check_pre_tool_hook now shares. It is left out because Share One Registration Helper Between the Agent-Safety Installer's PreToolUse Hooks #3517 scopes the shared check to the two PreToolUse loops, and the SessionEnd loop differs in substance: it checks the timeout, and its matcher note does not exclude the entry from the count. Filed as Share One Registration-Check Skeleton Between the Installer's PreToolUse and SessionEnd Hooks #3519 once the history showed every cross-copy fix landing on the shared skeleton.

Closes #3517

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: refactor/shared-hook-registration
• File: .coderabbit.yaml
• Commit: 208d4a7
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: aad91a6c-ba3e-4acf-abfc-683627866db5

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ptr727]

A recorded local strict-review pass covers head 208d4a7b805d469db3d3bd0367df1e7c61088a4d, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[Copilot]

🟢 Approval recommended

No unresolved review issues were identified, and the refactor preserves existing behavior.

No open issues 🎉

What changed in this PR

This pull request refactors the Claude agent-safety installer to share hook registration and PreToolUse validation logic while preserving existing behavior and generated settings.

Changes:

• Adds register_hook to deduplicate and place all three hooks in the appropriate event groups.
• Consolidates validation for the two PreToolUse hooks.
• Preserves the SessionEnd hook’s matcherless registration and existing diagnostics.

File	Description
host-setup/​agent-safety/​claude/​install.py	Adds shared hook registration and PreToolUse validation helpers while preserving existing settings and behavior.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@cb82cda). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #3518   +/-   ##
==========================================
  Coverage           ?   81.53%           
==========================================
  Files              ?       26           
  Lines              ?     8964           
  Branches           ?        0           
==========================================
  Hits               ?     7309           
  Misses             ?     1655           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	81.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.