Repository navigation
Mirror the Model-Tier Guard's CI Self-Tests in the Local Runbook - #3526
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review findings; the local runbook now matches the CI self-test sequence.
No open issues 🎉
What changed in this PR
Updates OPERATIONS.md so the local verification runbook mirrors the CI validation action’s model-tier guard self-tests.
Changes:
- Adds
model-tier-guard.py --selftest. - Adds
test_model_tier_guard.py. - Preserves the CI command order and existing local-versus-CI guidance.
| File | Description |
|---|---|
OPERATIONS.md |
Adds the two model-tier guard verification commands to the local CI-mirroring command block. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3526 +/- ##
========================================
Coverage 81.56% 81.56%
========================================
Files 26 26
Lines 8970 8970
========================================
Hits 7316 7316
Misses 1654 1654
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ain (#3521) ## Summary This promotes three changes to `main`: - [#3516](#3516) maps model tiers in one config, `spec/model-tiers.json`, carries the "Model Tiers" rule into the skills that dispatch, and adds a guard that refuses a highest-tier dispatch the maintainer did not allow. - [#3518](#3518) has the agent-safety installer's hooks share one registration helper. - [#3520](#3520) has those hooks share one registration-check loop. It also carries the fixes for this promotion's own review findings, each landed on `develop` first: - [#3522](#3522) requires a non-empty model name per tier and names both edits a model release makes. - [#3523](#3523) states what the highest-tier allowance covers and where the guard stops. - [#3524](#3524) rejects a tier sharing the maintainer-only model and states the allowance as conduct. - [#3525](#3525) matches the guard's alias boundaries regardless of case. - [#3526](#3526) mirrors the guard's CI self-tests in the local runbook. - [#3527](#3527) rejects a repeated tier name and names every hook the installer registers. Closes #3517 Closes #3519 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
This answers a fifth-round review finding on the promotion pull request #3521.
OPERATIONS.md's local command block mirrors the validate action's self-test step, but it lacked the two lines that step gained for the model-tier guard,model-tier-guard.py --selftestandtest_model_tier_guard.py. The block now carries both, in the action's order.Neither line behaves differently locally than in CI, so the runbook's prose about local-only differences needs no change.
🤖 Generated with Claude Code