Skip to content

Mirror the Model-Tier Guard's CI Self-Tests in the Local Runbook - #3526

Merged
ptr727 merged 1 commit into
developfrom
promotion-3521-operations-mirror
Oct 27, 2026
Merged

ptr727 merged 1 commit into
developfrom
promotion-3521-operations-mirror

Conversation

@ptr727

@ptr727 ptr727 commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Summary

This answers a fifth-round review finding on the promotion pull request #3521. OPERATIONS.md's local command block mirrors the validate action's self-test step, but it lacked the two lines that step gained for the model-tier guard, model-tier-guard.py --selftest and test_model_tier_guard.py. The block now carries both, in the action's order.

Neither line behaves differently locally than in CI, so the runbook's prose about local-only differences needs no change.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 27, 2026 19:54
@ptr727

ptr727 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 7b8a4265f4da3766812549131b780bf1018ca7f8, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review findings; the local runbook now matches the CI self-test sequence.

No open issues 🎉

What changed in this PR

Updates OPERATIONS.md so the local verification runbook mirrors the CI validation action’s model-tier guard self-tests.

Changes:

  • Adds model-tier-guard.py --selftest.
  • Adds test_model_tier_guard.py.
  • Preserves the CI command order and existing local-versus-CI guidance.
File Description
OPERATIONS.md Adds the two model-tier guard verification commands to the local CI-mirroring command block.

Review effort: Lite

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.56%. Comparing base (97997b2) to head (7b8a426).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3526   +/-   ##
========================================
  Coverage    81.56%   81.56%           
========================================
  Files           26       26           
  Lines         8970     8970           
========================================
  Hits          7316     7316           
  Misses        1654     1654           
Flag Coverage Δ
python-3.13 81.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 557ac28 into develop Oct 27, 2026
14 checks passed
@ptr727
ptr727 deleted the promotion-3521-operations-mirror branch October 27, 2026 20:06
ptr727 added a commit that referenced this pull request Oct 27, 2026
…ain (#3521)

## Summary

This promotes three changes to `main`:

- [#3516](#3516) maps
model tiers in one config, `spec/model-tiers.json`, carries the "Model
Tiers" rule into the skills that dispatch, and adds a guard that refuses
a highest-tier dispatch the maintainer did not allow.
- [#3518](#3518) has the
agent-safety installer's hooks share one registration helper.
- [#3520](#3520) has those
hooks share one registration-check loop.

It also carries the fixes for this promotion's own review findings, each
landed on `develop` first:

- [#3522](#3522) requires
a non-empty model name per tier and names both edits a model release
makes.
- [#3523](#3523) states
what the highest-tier allowance covers and where the guard stops.
- [#3524](#3524) rejects a
tier sharing the maintainer-only model and states the allowance as
conduct.
- [#3525](#3525) matches
the guard's alias boundaries regardless of case.
- [#3526](#3526) mirrors
the guard's CI self-tests in the local runbook.
- [#3527](#3527) rejects a
repeated tier name and names every hook the installer registers.

Closes #3517
Closes #3519

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants