fix: support Bitkit local wallet tests - #11
Conversation
ovitrif
left a comment
There was a problem hiding this comment.
One blocking issue and one non-blocking issue remain:
- Creator-demo boots with
--external-walletand publishes the creator profile only after wallet approval, but reader-demo still binds once from.local/creator-public/profile.jsonand can run against a stale prior identity or terminal-fail while the profile is missing. /api/demo-auth/startstill returns a recovery-file authenticate command under--external-wallet, so the creator page can steer operators onto a local recovery identity instead of the Bitkit wallet.
3bb5cb9 to
8c5dd3f
Compare
|
@jvsena42 could you please review the current head? The external-wallet identity/profile fixes have been exercised in the clean iOS and Android Locks → Paykit → Bitkit E2E flow, and all prior review threads are resolved. |
8c5dd3f to
be5d31e
Compare
be5d31e to
1a5f97c
Compare
ovitrif
left a comment
There was a problem hiding this comment.
Thanks for addressing the recovery-auth command. One blocking issue remains: the waiting_for_creator gate still waits on the private content-creator profile path, so Compose external-wallet never observes the published creator-public profile and the reader never prepares.
dzdidi
left a comment
There was a problem hiding this comment.
LGTM, looks like it still working with the non-bitkit tests. May you please confirm? Once confirmed it is merge
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
Signed-off-by: dzdidi <dzdidi@users.noreply.github.com>
Summary
This is intentionally stacked on #10 because it hardens and completes that demo's app-wallet test path.
Contract and risk impact
Verification
npm --prefix examples/js-sdk run checknpm --prefix examples/js-sdk run validate:paykit-composenode examples/js-sdk/scripts/smoke-paykit-compose.mjsdocker compose -f compose.paykit-local-demo.yaml build creator-demo8080to18080waiting, Homegate returned a valid signup response, creator preflight passed, and Fulcrum answered an Electrum version requestDocumentation
Updated
examples/js-sdk/README.mdfor the external-wallet flow, local service endpoints, and runtime reset.Checklist