chore(rivet): RQ-59-MEASURE and RQ-59-WCETI64 are implemented - #1027
Merged
Conversation
#1025 and #1026 merged. v0.59 now 6/11. Like RQ-59-REACH, MEASURE is implemented on a verdict rather than a change: DO NOT FLIP. The colourer wins on net (-122 B, -31 insns, -72 push/pop regs) but does not dominate — frame traffic +22 — and the named root cause is that the Chaitin occurrence-count cost metric prices a 2-byte register copy and a 4-byte frame reload identically. Delivering the verdict IS the artifact; the flip is a separate gated step needing silicon evidence. WCETI64 closed #936's residual: all four ops priced from the real encoder's byte length, and the OS shape that motivated the issue (narrow an i64 read to i32) now bounds at 80 cycles instead of declining. Two of the four ops moved no decline and the lane said so rather than counting them as wins. Refs #242, #936.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1025 and #1026 merged. v0.59 now 6/11.
Like
RQ-59-REACH, MEASURE is implemented on a verdict rather than a change: DO NOT FLIP. The colourer wins on net (−122 B, −31 instructions, −72 push/pop registers) but does not dominate — frame traffic +22 — and the named root cause is that the Chaitin occurrence-count cost metric prices a 2-byte register copy and a 4-byte frame reload identically. Delivering the verdict is the artifact; the flip is a separate gated step needing gale silicon evidence.WCETI64 closed #936's residual: all four ops priced from the real encoder's byte length (never a hand mirror — that method was tried in #936 and found unsound at authoring). The OS shape that motivated the issue — narrowing an i64 read to i32 — now bounds at 80 cycles instead of declining. Two of the four ops moved no decline, and the lane reported that rather than counting them as wins.
claim_check50/50. Rivet artifact only.Refs #242, #936.