Repository navigation
Document component state migrations - #21865
Conversation
Sentinel — merge gate status (preview)Warning
|
| Gate | What it needs | |
|---|---|---|
| 🔴 | G1 review-ran | No current review for 4d413a383 — push to refresh, comment @claude #update-review, or flip the PR to draft and back to ready. |
| ✅ | G2 findings-answered | Nothing to do: every finding answered. |
| 🔴 | G3 right-approver | Needs approval from a member of any review team (pulumi/docs-blog-review, pulumi/docs-guild, pulumi/docs-marketing-review, pulumi/docs-tools) or a repository administrator — no qualifying human approval at this head (bot approvals never count). CamSoper approved an earlier commit; re-approve at 4d413a383. |
| ➖ | G4 infra-evidence | Doesn't apply to this PR: no changed path affects the deploy. |
| ➖ | G5 oversized-ack | Doesn't apply to this PR: not oversized. |
Break glass: a member of a routing team (.github/review-routing.yml teams:) can apply review:waived, which is logged.
Evaluated at head 4d413a383.
|
Your site preview for commit 4d413a3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-21865-4d413a38.s3-website.us-west-2.amazonaws.com Changed pages: |
Reviewer's guide v2 — not for the authorTip This is the reviewer's guide. Work through the PR author: your to-do list is the other review comment, "Author action guide" — nothing on this card is yours. Approval needed from: @pulumi/docs-guild — any member's approval satisfies the merge gate. Note What this PR changes:
The main risk is engine behavior the docs describe that no public source confirms yet: ordering, validation, persistence, and secrets handling. Fact-check, Hugo build, link and frontmatter checks, and a read of the code samples ran. Review confidence:
|
| ID | Where | Finding |
|---|---|---|
| F2 | content/docs/iac/guides/building-extending/components/state-migrations.md L193-203 |
The closing sentence of Restrictions is a comma splice that reads as contradicting the list above it; split it into two sentences. ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F3 | content/docs/iac/concepts/resources/options/statemigrations.md L31 |
"In the stateMigrations callback API, the registering URN can differ from the root's prior URN when Pulumi matches it through an alias." — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F4 | content/docs/iac/concepts/resources/options/statemigrations.md L33 |
"In a stateMigrations callback result, every input URN must either remain in the result or have a successor mapping to a resource in the result, but not both." — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F5 | content/docs/iac/concepts/resources/options/statemigrations.md L67 |
"The Go SDK exposes a StateMigrationResult type in the github.com/pulumi/pulumi/sdk/v3/go/pulumi package, documented at…" — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F6 | content/docs/iac/guides/building-extending/components/state-migrations.md L59 |
"Pulumi state migration callbacks receive decrypted secret values inside their serialized secret envelopes." — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F7 | content/docs/iac/guides/building-extending/components/state-migrations.md L148 |
"Pulumi supplies the component itself first to migration callbacks, followed by its descendants in snapshot order, representing the subtree defined by parent…" — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F8 | content/docs/iac/guides/building-extending/components/state-migrations.md L150 |
"Ordinary string values are not rewritten by Pulumi's successor-mapping rewrite during a state migration." — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F9 | content/docs/iac/guides/building-extending/components/state-migrations.md L153 |
"A pulumi up (update) persists the state migration before proceeding with the affected resources." — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
| F11 | content/docs/iac/guides/building-extending/components/state-migrations.md L195-196 |
"Pulumi rejects state-changing migrations when there are pending operations in the snapshot, requiring resolution with pulumi refresh before migrating." — verdict: unverifiable ✋ Accepted as-is by julienp on 2026-09-24. author accepted all open items; stated reason: "shut up" |
Editorial stances introduced by this PR
Superlative, ranking, or comparative language the diff adds. No verdict — a page's own framing isn't fact-checkable — but confirm each is a stance the docs should take, and that no agent-written rewrite introduced it unasked.
None — the extractor found no positioning or comparison language in this PR's added lines.
✅ What you can rubber-stamp
- Facts: 55 factual claims checked — 45 verified clean, 8 flagged in the
⚠️ list, 2 settled — see the evidence page. - Mechanics: frontmatter sweep ran; Hugo build green; 11 added internal link(s) resolve; 1 detector finding(s) filed above.
- Style: 0 advisory suggestions left with the author; never blocking.
💡 Pre-existing issues in touched files: 0 — details on the evidence page.
📎 Full evidence: verification trail, investigation log, review history.
Review v2 · updated 2026-09-25T00:47:12Z · head commit 8364635
For the reviewer: the @claude <your point> #update-review re-adjudicates with your input.
Author action guide v2 — nothing blocks mergeNote Nothing here blocks merge — no open items need an answer from you. A human reviewer still approves the merge. This PR adds a component state migrations guide, a 🚨 Fix or disagreeNothing to fix — this section is empty. ❓ Questions for youNo open questions for you. Style suggestionsOptional polish from pattern-based linting — never blocking, not counted above. Take the ones that read better and ignore the rest. ✏️ marks one you can apply from the Files changed tab — use Add suggestion to batch on each, then Commit suggestions to take several in a single commit. None. 📎 Full evidence: verification trail, investigation log, review history. Review v2 · updated 2026-09-25T00:47:12Z · head commit 8364635 How to answerEvery 🚨 and ❓ item above needs one of these before merge:
The Please don't edit, hide, or delete this comment — it is the review's record. Full mechanics: CONTRIBUTING.md §AI-assisted contributions. |
|
Looks like an answer to F20 — to make it count, reply |
|
@claude you are terrible at this:
|
|
Claude finished @julienp's task in 1m 12s —— View job Checked against pulumi v3.264.0: your answers hold, but the gate needs one more comment from youYou're right that the review shouldn't have sent most of these to you. I cloned
F3 note: in the v3.264.0 tag, Why the card still says 8 items block mergeYour comment didn't include After that, the only open gate is G3: an approval from any docs review team member. I pushed no changes, as you asked on F5 and F7. I'm also passing this along as feedback: none of F8, F9, or F20–F22 should have reached you as questions. The verifier could have checked each one against the tagged |
|
🤖 Review auto-refreshed — the latest push only touched lines with outstanding findings. |
|
@claude accepting all open items — shut up #update-review |
|
🤖 Review updated on @julienp's request. |
|
This change is part of the following stack: Change managed by git-spice. |
|
/resolve F2 accepted: Style nit; readable as written, and the author declined it. Generated by Claude Code |
Introduced in https://github.com/pulumi/pulumi/releases/tag/v3.264.0