Skip to content

Show the 👀 on PRs whose branch predates the reaction helper - #21918

Merged
CamSoper merged 1 commit into
masterfrom
camsoper/magical-gauss-rvf2iz
Sep 25, 2026
Merged

CamSoper merged 1 commit into
masterfrom
camsoper/magical-gauss-rvf2iz

Conversation

@CamSoper

Copy link
Copy Markdown
Contributor

Proposed changes

Follow-up to #21908. Two review steps check out the PR head and ran that branch's copy of ack-request.sh:

  • the update lane's progress step in claude-update.yml
  • the claude-review job in claude-code-review.yml, both its progress step and its finalize step

A branch cut before #21908 has no copy of the script, so those runs silently fell back to the old "Working on it" / "Reviewing" spinner comment instead of putting a 👀 on the request. That's every PR open when #21908 merged.

Both jobs now fetch the default branch's copy of the script into $RUNNER_TEMP and run that. If the fetch fails, they still fall back to the spinner. The other callers already get the default branch's copy: claude-new.yml and the publish job check out master, and the update lane's finalize step runs after the action restores .claude/ from master.

Testing

Known and expected: an initial review of a PR whose branch predates #21908 still renders the old card layout (with 📎), because that lane builds the card with the PR head's scripts on purpose. Every parser accepts both layouts, and the next #update-review re-renders the card in the new one.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GKHS8qr1o8N7QkAdtHyWPz


Generated by Claude Code

The update lane's progress step and the initial lane's claude-review job
check out the PR head, so they ran the PR's copy of ack-request.sh. Every
branch cut before #21908 has no copy, so those PRs silently fell back to
the "Working on it" / "Reviewing" spinner comment instead of the 👀.
Observed on #21760 right after the merge: both #update-review and
#new-review posted a spinner (then cleaned up and ended on 🚀).

Fetch the helper from the default branch into $RUNNER_TEMP instead. The
spinner stays as the fallback if the fetch fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GKHS8qr1o8N7QkAdtHyWPz
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Sentinel — merge gate status (preview)

Warning

⚠️ Preview mode — this check is NOT blocking your merge

The Sentinel is in preview (report-only) mode: its check-run concludes neutral whatever the gates below say, so nothing here gates this PR. The rows are informational and safe to ignore for now. It would have concluded failure.

This will be enforced in the near future. Once it is, every row below has to be green before this PR can merge. The rows are the sign-offs a merge needs — some yours, some a reviewer's or a deploy's. Tell us in #docs if one looks wrong.

1 of 5 gates would block this merge once the Sentinel is enforced.

Gate What it needs
✅ G1 review-ran Nothing to do: review current at 6aac46c80.
✅ G2 findings-answered Nothing to do: every finding answered.
🔴 G3 right-approver Needs approval from a member of any review team (pulumi/docs-blog-review, pulumi/docs-guild, pulumi/docs-marketing-review, pulumi/docs-tools) or a repository administrator — no qualifying human approval at this head (bot approvals never count).
➖ G4 infra-evidence Doesn't apply to this PR: no changed path affects the deploy.
➖ G5 oversized-ack Doesn't apply to this PR: not oversized.

Break glass: a member of a routing team (.github/review-routing.yml teams:) can apply review:waived, which is logged.

Evaluated at head 6aac46c80.

@pulumi-bot

Copy link
Copy Markdown
Collaborator

@CamSoper
CamSoper marked this pull request as ready for review September 25, 2026 23:44
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:infra PR touches workflows, scripts, infra, Makefile, or build config labels Sep 25, 2026
@pulumi-bot
pulumi-bot requested a review from a team September 25, 2026 23:45
@github-actions github-actions Bot added review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Reviewer's guide v1 — not for the author

Tip

This is the reviewer's guide. Work through the ⚠️ checklist below, then approve — approving asserts only that the ⚠️ items looked right to you. Machine-verified this run: links, shortcodes, page metadata, and every claim marked verified (receipts on the evidence page). Code samples are read, not compiled.

PR author: your to-do list is the other review comment, "Author action guide" — nothing on this card is yours.

Approval needed from: @pulumi/docs-tools — any member's approval satisfies the merge gate.

Note

What this PR changes:

  • claude-code-review.yml progress step: fetches the default branch's ack-request.sh into $RUNNER_TEMP instead of running the PR head's copy.
  • claude-code-review.yml finalize step: reuses the fetched copy (refetching if absent) for the 👀 clear and 🚀 ack, falling back to a comment.
  • claude-update.yml progress step: same default-branch fetch for the update lane's 👀.

A blocker here would be a call site still running a missing PR-head copy, or a failed fetch that suppresses the spinner fallback. The infra pass read each changed step, the checkout ref of every job invoking ack-request.sh (the publish job checks out the default branch, so its direct calls are fine), and the empty-file fallback path.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH

⚠️ Check these before approving

No findings to check — but the editorial stances below still need a human eye.

Editorial stances introduced by this PR

Superlative, ranking, or comparative language the diff adds. No verdict — a page's own framing isn't fact-checkable — but confirm each is a stance the docs should take, and that no agent-written rewrite introduced it unasked.

None — the extractor found no positioning or comparison language in this PR's added lines.

✅ What you can rubber-stamp

  • Facts: no factual claims found in the changed lines.
  • Mechanics: no internal links added.
  • Style: 0 advisory suggestions left with the author; never blocking.

Pre-existing issues in touched files: 0 — details on the evidence page.

Full evidence: verification trail, investigation log, review history.

Review v1 · updated 2026-09-25T23:46:33Z · head commit 6aac46c


For the reviewer: the ⚠️ items above are the minutes that matter — the receipts for everything machine-verified are on the evidence page. The author's open items live on their own card (the comment headed "Author action guide"); while any are open, a Waiting on the author list above tracks them, and merge stays blocked until they're answered. If something here seems off, comment on the PR — @claude <your point> #update-review re-adjudicates with your input.

@github-actions

Copy link
Copy Markdown
Contributor

Author action guide v1 — nothing blocks merge

Note

Nothing here blocks merge — no open items need an answer from you. A human reviewer still approves the merge.

This PR makes the PR-head review and update jobs fetch ack-request.sh from the default branch so older branches get the 👀 reaction; the review traced every call site's checkout ref and fallback path.

Full evidence: verification trail, investigation log, review history.

Review v1 · updated 2026-09-25T23:46:33Z · head commit 6aac46c


How to answer — fix it, disagree with it, or accept it as-is (click for the exact replies)

Every 🚨 and ❓ item above needs one of these before merge:

  1. Fix it — push the change. If your push lines up with the flagged lines, this card shows a 🔄 banner within a minute and then refreshes itself. No banner? Comment:

    @claude I pushed a fix for F1 #update-review
    
  2. Disagree with it — say which item and why; the review re-checks with your input:

    @claude F2: <your reasoning — e.g. where the figure comes from> #update-review
    

    Either way your answer counts: the review marks the item resolved, or keeps it with a 🛡️ note for your human reviewer to weigh — it stops blocking merge in both cases.

  3. Accept it as-is — you own the PR; a one-line reason is a valid answer, and your reviewer sees it beside the finding:

    @claude F2: accepting as-is — <your reason> #update-review
    

    To accept every open item at once: @claude accepting all open items — <reason> #update-review.

The #update-review hashtag matters — it routes your reply to this review, and (besides pushing a fix) it is the only reply that unblocks merge. A bare @claude gets you ad-hoc help and leaves this card — and the merge block — untouched.

Full mechanics: CONTRIBUTING.md §AI-assisted contributions.

Please don't edit, hide, or delete this comment — it is the review's record.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Sep 25, 2026
@CamSoper
CamSoper merged commit 86e4ca6 into master Sep 25, 2026
17 checks passed
@CamSoper
CamSoper deleted the camsoper/magical-gauss-rvf2iz branch September 25, 2026 23:50

This branch was successfully deployed

1 active deployment
testing — 6aac46c8 Deployed Sep 25, 2026 by CamSoper via Do cleanup #14432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants