Repository navigation
Show the 👀 on PRs whose branch predates the reaction helper - #21918
Conversation
The update lane's progress step and the initial lane's claude-review job check out the PR head, so they ran the PR's copy of ack-request.sh. Every branch cut before #21908 has no copy, so those PRs silently fell back to the "Working on it" / "Reviewing" spinner comment instead of the 👀. Observed on #21760 right after the merge: both #update-review and #new-review posted a spinner (then cleaned up and ended on 🚀). Fetch the helper from the default branch into $RUNNER_TEMP instead. The spinner stays as the fallback if the fetch fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHS8qr1o8N7QkAdtHyWPz
Sentinel — merge gate status (preview)Warning
|
| Gate | What it needs | |
|---|---|---|
| ✅ | G1 review-ran | Nothing to do: review current at 6aac46c80. |
| ✅ | G2 findings-answered | Nothing to do: every finding answered. |
| 🔴 | G3 right-approver | Needs approval from a member of any review team (pulumi/docs-blog-review, pulumi/docs-guild, pulumi/docs-marketing-review, pulumi/docs-tools) or a repository administrator — no qualifying human approval at this head (bot approvals never count). |
| ➖ | G4 infra-evidence | Doesn't apply to this PR: no changed path affects the deploy. |
| ➖ | G5 oversized-ack | Doesn't apply to this PR: not oversized. |
Break glass: a member of a routing team (.github/review-routing.yml teams:) can apply review:waived, which is logged.
Evaluated at head 6aac46c80.
|
Your site preview for commit 6aac46c is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-21918-6aac46c8.s3-website.us-west-2.amazonaws.com |
Reviewer's guide v1 — not for the authorTip This is the reviewer's guide. Work through the PR author: your to-do list is the other review comment, "Author action guide" — nothing on this card is yours. Approval needed from: @pulumi/docs-tools — any member's approval satisfies the merge gate. Note What this PR changes:
A blocker here would be a call site still running a missing PR-head copy, or a failed fetch that suppresses the spinner fallback. The infra pass read each changed step, the checkout ref of every job invoking Review confidence:
|
Author action guide v1 — nothing blocks mergeNote Nothing here blocks merge — no open items need an answer from you. A human reviewer still approves the merge. This PR makes the PR-head review and update jobs fetch Full evidence: verification trail, investigation log, review history. Review v1 · updated 2026-09-25T23:46:33Z · head commit 6aac46c How to answer — fix it, disagree with it, or accept it as-is (click for the exact replies)Every 🚨 and ❓ item above needs one of these before merge:
The Full mechanics: CONTRIBUTING.md §AI-assisted contributions. Please don't edit, hide, or delete this comment — it is the review's record. |
Proposed changes
Follow-up to #21908. Two review steps check out the PR head and ran that branch's copy of
ack-request.sh:claude-update.ymlclaude-reviewjob inclaude-code-review.yml, both its progress step and its finalize stepA branch cut before #21908 has no copy of the script, so those runs silently fell back to the old "Working on it" / "Reviewing" spinner comment instead of putting a 👀 on the request. That's every PR open when #21908 merged.
Both jobs now fetch the default branch's copy of the script into
$RUNNER_TEMPand run that. If the fetch fails, they still fall back to the spinner. The other callers already get the default branch's copy:claude-new.ymland the publish job check out master, and the update lane's finalize step runs after the action restores.claude/from master.Testing
#update-reviewposted the spinner, then deleted it and ended on 🚀. The card refreshed correctly into the new format and the finding resolved.#new-reviewput up the 👀 (fromclaude-new.yml), plus a spinner from the review job, then ended on 🚀 with no leftover comments.make test-review-pipelineand actionlint pass.bash -npasses on every edited step.master.Known and expected: an initial review of a PR whose branch predates #21908 still renders the old card layout (with 📎), because that lane builds the card with the PR head's scripts on purpose. Every parser accepts both layouts, and the next
#update-reviewre-renders the card in the new one.🤖 Generated with Claude Code
https://claude.ai/code/session_01GKHS8qr1o8N7QkAdtHyWPz
Generated by Claude Code