chore: drop the stale zizmor --no-progress workaround - #747
Merged
Conversation
zizmorcore/zizmor#582 was closed as completed on 2025-03-11: zizmor only renders the progress bar when its output is a tty. prek pipes hook output rather than allocating a pty -- even under --color=always, where it forces colour through the environment instead -- so zizmor sees a non-tty and emits plain log lines, locally and in CI alike. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zizmorhook carries--no-progress, pointing atzizmorcore/zizmor#582. That
issue is closed as completed (2025-03-11), and the flag no longer earns its
place here.
Evidence
The issue is resolved. #582 turned out not to be a zizmor bug at all: zizmor
already suppressed the TUI on a non-tty, and the reporter's progress bar came
from
pre-commit.cipresenting itself as a tty. The--no-progressescapehatch was re-added in #589 and
shipped in v1.5.0, for that kind of tty-faking runner.
The pinned version postdates the fix.
uv.lockpinszizmor==1.29.0(2026-08-01), far past v1.5.0 (2025-03-11).
Non-tty output was checked. Running the hook the way
make lintand CI do,with output captured rather than on a terminal, yields no progress bar — zero
carriage returns, zero erase-line sequences, zero bar glyphs:
Worth noting
--color=alwaysdoes not reintroduce the problem: prek forcescolour through the environment rather than by allocating a pty, so the log lines
come out coloured while the progress bar stays suppressed. Attaching prek itself
to a real pty behaves the same — the only carriage returns belong to prek's own
"Running hooks..." spinner. For contrast, giving zizmor a genuine pty
(
script -q out.txt uv run zizmor ...) does produce the full TUI — 338 carriagereturns, 327 erase-line sequences — so this is about the hook's environment, not
about zizmor having dropped the feature.
uv run prek run --show-diff-on-failure --color=always --all-filespasses, alleleven hooks green.
Checklist:
🤖 Generated with Claude Code