Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
- Coverage 95.85% 95.84% -0.01%
==========================================
Files 20 20
Lines 1880 1879 -1
==========================================
- Hits 1802 1801 -1
Misses 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I like the organization and style. The size of the MR will require some time to review. |
|
Thanks for putting this together - I reviewed it mainly from the newcomer/readability angle that prompted #1507. The overall structure is much clearer. I spotted three places where the wording might be worth tightening:
I also checked the conversion/transformation distinction because you flagged it in the PR description; the current explanation reads clearly to me and I don’t have a substantive change to suggest there. |
0f2e7e0 to
3ad7fc7
Compare
|
Thanks @mackenziereading19! That's exactly what I was looking for. I've made changes based on what you said. I also had Claude change the language around "most software" to "many software packages" as I don't know if anyone is in a position to say what most software does. |
|
And yes @snowman2 this is big. Hopefully you and others can find time to review. I think this is the type of content that could have saved me a lot of confusion 15+ years ago when I started working with projections and resampling. I had to read a paper book! 😮 Oh great: |
As mentioned in #1507, the documentation is a little lacking when it comes to explaining the basic concepts of what pyproj works with. The acronyms are especially difficult to parse if you're not already well versed in them.
I asked Claude to take a swing at resolving #1507 and it asked me how far it should take it. I told it to go far and add new documents for a full glossary and basic concepts. I think it did a really good job. I've manually reviewed everything in this pull request even though Claude wrote it all. I made some small edits myself. I also had Claude update any implicit references to PROJ documentation with the
proj:prefix so if in the future pyproj ever adds documents or references matching the PROJ documents these references don't unintentionally start going to the pyproj docs.Concerns Claude had about what it wrote:
Concerns I have:
CC @jonas8217, @savjaylade84, and @mikelcatania who commented on the related issue.
history.rstfor all changes andapi/*.rstfor new API