Repository navigation
2. Безымянный Сергей Андреевич. 613 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,120 +1,91 @@ | ||
| """Create/read/update/delete operations over the in-memory product store. | ||
|
|
||
| Every operation takes the store -- a list of | ||
| :data:`~src.part2.storage.Product` tuples -- as its first argument and | ||
| works on it in place. The failure path never raises: the operation prints | ||
| an explanatory message to stdout and returns ``None``. | ||
|
|
||
| The identifier of a new product is derived from the store itself | ||
| (:func:`generate_product_id`): one past the greatest identifier in use, or | ||
| :data:`~src.part2.storage.PRODUCT_ID_MIN` when the store is empty. | ||
| Product names are kept unique -- :func:`create_product` refuses a name that | ||
| is already taken. | ||
| """ | ||
|
|
||
| from decimal import Decimal | ||
|
|
||
| from .storage import ( # noqa: F401 | ||
| from .storage import ( | ||
| NAME_INDEX, | ||
| PRODUCT_ID_INDEX, | ||
| PRODUCT_ID_MIN, | ||
| Product, | ||
| ) | ||
| from .utils import normalize_price # noqa: F401 | ||
| from .utils import normalize_price | ||
|
|
||
|
|
||
| def generate_product_id(storage: list[Product]) -> int: | ||
| """Choose the identifier for the next product added to ``storage``. | ||
| def create_product( | ||
| storage: list[Product], | ||
| fields: tuple[str, Decimal, int], | ||
| ) -> int | None: | ||
| product_name, product_price, product_quantity = fields | ||
|
|
||
| Args: | ||
| storage: The product store to inspect. | ||
| for product in storage: | ||
| if product_name == product[NAME_INDEX]: | ||
| print(f"Product name {product_name} is already taken.") | ||
| return None | ||
|
|
||
| Returns: | ||
| One past the greatest identifier currently held in ``storage``, or | ||
| :data:`~src.part2.storage.PRODUCT_ID_MIN` when ``storage`` is | ||
| empty. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| product_id = generate_product_id(storage) | ||
|
|
||
| storage.append( | ||
| ( | ||
| product_id, | ||
| product_name, | ||
| normalize_price(product_price), | ||
| product_quantity, | ||
| ) | ||
| ) | ||
|
|
||
| return product_id | ||
|
|
||
| def create_product( | ||
| storage: list[Product], fields: tuple[str, Decimal, int] | ||
| ) -> int | None: | ||
| """Append a new product to ``storage`` and return its new identifier. | ||
|
|
||
| Args: | ||
| storage: The product store to append to; modified in place on | ||
| success. | ||
| fields: A ``(name, price, quantity)`` tuple describing the product. | ||
| ``price`` is a :class:`~decimal.Decimal` amount and is rounded | ||
| to the stored money precision before it is saved. | ||
| def generate_product_id(storage: list[Product]) -> int: | ||
| if not storage: | ||
| return PRODUCT_ID_MIN | ||
|
|
||
| Returns: | ||
| The identifier generated for the new product, or ``None`` when a | ||
| product with the same name already exists. In the ``None`` case | ||
| ``storage`` is left unchanged and a message naming the clashing | ||
| name is printed. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| max_id = max(product[PRODUCT_ID_INDEX] for product in storage) | ||
|
|
||
| return max_id + 1 | ||
|
|
||
| def read_product(storage: list[Product], product_id: int) -> Product | None: | ||
| """Return the product stored under ``product_id``. | ||
|
|
||
| Args: | ||
| storage: The product store to search. | ||
| product_id: The identifier to look up. | ||
| def read_product( | ||
| storage: list[Product], | ||
| product_id: int, | ||
| ) -> Product | None: | ||
| for product in storage: | ||
| if product[PRODUCT_ID_INDEX] == product_id: | ||
| return product | ||
|
|
||
| Returns: | ||
| The matching ``(product_id, name, price, quantity)`` record, or | ||
| ``None`` when no product carries that identifier (a message is | ||
| printed in that case). | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return (0, "", Decimal(0), 0) | ||
| print(f"No product with id {product_id}") | ||
| return None | ||
|
|
||
|
|
||
| def update_product( | ||
| storage: list[Product], | ||
| product_id: int, | ||
| fields: tuple[str, Decimal, int], | ||
| ) -> Product | None: | ||
| """Overwrite the fields of the product stored under ``product_id``. | ||
|
|
||
| The identifier itself is preserved; only ``name``, ``price`` and | ||
| ``quantity`` are replaced. | ||
|
|
||
| Args: | ||
| storage: The product store to modify; the matching record is | ||
| replaced in place on success. | ||
| product_id: The identifier of the product to change. | ||
| fields: A ``(name, price, quantity)`` tuple with the new values. | ||
| ``price`` is a :class:`~decimal.Decimal` amount and is rounded | ||
| to the stored money precision before it is saved. | ||
|
|
||
| Returns: | ||
| The updated ``(product_id, name, price, quantity)`` record, or | ||
| ``None`` when no product carries that identifier (``storage`` is | ||
| left unchanged and a message is printed). | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return (0, "", Decimal(0), 0) | ||
|
|
||
|
|
||
| def delete_product(storage: list[Product], product_id: int) -> int | None: | ||
| """Remove the product stored under ``product_id`` from ``storage``. | ||
|
|
||
| Args: | ||
| storage: The product store to remove from; modified in place on | ||
| success. | ||
| product_id: The identifier of the product to remove. | ||
|
|
||
| Returns: | ||
| ``product_id`` when a product was removed, or ``None`` when no | ||
| product carried that identifier (``storage`` is left unchanged and | ||
| a message is printed). | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| for index, product in enumerate(storage): | ||
| if product[PRODUCT_ID_INDEX] == product_id: | ||
| new_name, new_price, new_quantity = fields | ||
|
|
||
| new_product: Product = ( | ||
| product_id, | ||
| new_name, | ||
| normalize_price(new_price), | ||
| new_quantity, | ||
| ) | ||
|
|
||
| storage[index] = new_product | ||
| return new_product | ||
|
|
||
| print(f"No product with id {product_id}") | ||
| return None | ||
|
|
||
|
|
||
| def delete_product( | ||
| storage: list[Product], | ||
| product_id: int, | ||
| ) -> int | None: | ||
| for index, product in enumerate(storage): | ||
| if product[PRODUCT_ID_INDEX] == product_id: | ||
| storage.pop(index) | ||
| return product_id | ||
|
|
||
| print(f"No product with id {product_id}.") | ||
| return None | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Цикл:
встречается несколько раз, лучше было бы использовать везде
read_product. Код был бы понятнее.Пункт S1