Repository navigation
1. Раджабов Руслан Ильгамович. 614 - #17
Open
somet1me123 wants to merge 23 commits into
Open
somet1me123 wants to merge 23 commits into
somet1me123 wants to merge 23 commits into
Conversation
EvgrafovMichail
left a comment
EvgrafovMichail
left a comment
Member
There was a problem hiding this comment.
Решение оформлено аккуратно. Старайтесь переиспользовать код и результаты вычислений без использования копипасты.
Итог за тесты: 10/10
Итоговый штраф: 1
Итог: 9/10
| return 0 | ||
| time_stamp = read_current_millis(epoch_ms) | ||
| if not (0 <= node_id <= NODE_ID_MAX): | ||
| print("node_id must be in [0, 2**10-1]") |
Member
There was a problem hiding this comment.
Лучше не делать такую инъекцию констант в строку. При изменении значения константы придется вручную вспоминать, где вы сделали инъекцию, и менять вручную это сообщение. Вместо этого, лучше использовать f-строки и вставлять значения констант
| print("overflows") | ||
| return None | ||
| snowflake_id = ( | ||
| (time_stamp << (NODE_ID_BITS + SEQUENCE_ID_BITS)) |
Member
There was a problem hiding this comment.
Вычисление сдвига дублируется. Нарушение критерия S1. Штраф 1 балл
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.