Repository navigation
1-4. Рамазанова Дарина Наимовна. 614 - #25
Open
darinaramazanova wants to merge 12 commits into
Open
darinaramazanova wants to merge 12 commits into
darinaramazanova wants to merge 12 commits into
Conversation
EvgrafovMichail
left a comment
EvgrafovMichail
left a comment
Member
There was a problem hiding this comment.
Итог за тесты: 7.6
Итоговый штраф: 1
Итог после округления: 7
| return None | ||
|
|
||
| return (vremya << (NODE_ID_BITS + SEQUENCE_ID_BITS)) | ( | ||
| node_id << (SEQUENCE_ID_BITS | sequence_id) |
Member
There was a problem hiding this comment.
Вы ошиблись с расстановкой скобок. Правильно так:
(
(vremya << (NODE_ID_BITS + SEQUENCE_ID_BITS))
| (node_id << SEQUENCE_ID_BITS )
| sequence_id
)Это вычислительная ошибка, из-за которой часть тестов не пройдена
| print("Timestamps overflows") | ||
| return None | ||
|
|
||
| return (vremya << (NODE_ID_BITS + SEQUENCE_ID_BITS)) | ( |
Member
There was a problem hiding this comment.
Вычисление этого сдвига встречается в коде несколько раз. Это нарушает критерий S1. Минус балл
| print(f"sequence_id must be in [0; {SEQUENCE_ID_MAX}], have {sequence_id}") | ||
| return None | ||
|
|
||
| vremya = read_current_millis(epoch_ms) |
Member
There was a problem hiding this comment.
Лучше не использовать транслитерацию для именования переменных. Используйте валидные английские слова при выборе имен переменных. Например, timestamp_ms
darinaramazanova
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.