Repository navigation
Conversation
EvgrafovMichail
left a comment
EvgrafovMichail
left a comment
Member
There was a problem hiding this comment.
Решение хорошее. Единственное замечания - не занимайтесь копипастой. Если что-то уже рассчитано - переиспользуйте рассчитанные значения, а не дублируйте расчеты.
Итог за тесты: 10/10
Итоговый штраф: 1
Бонус за реализацию тестов: 1
Итог: 10/10
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| return (snowflake_id >> SEQUENCE_ID_BITS) & ((1 << NODE_ID_BITS) - 1) |
Member
There was a problem hiding this comment.
Вы же определили константу NODE_ID_MAX, зачем рассчитывать это значение еще раз тут: (1 << NODE_ID_BITS) - 1. Получается копипаста, нарушение критерия S1 - минус балл
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| return (snowflake_id) & ((1 << SEQUENCE_ID_BITS) - 1) |
| return None | ||
|
|
||
| return ( | ||
| (elapsed << (NODE_ID_BITS + SEQUENCE_ID_BITS)) |
Member
There was a problem hiding this comment.
Это значение тоже рассчитывалось ранее. Так что аналогично
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.