Repository navigation
1. Кабанов Дмитрий Константинович 614 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
34a9ea1
1601bfc
5586877
9362de2
52ad025
cf64745
895e45d
4fde3b3
79b2121
ae6caed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,6 @@ | ||
| """Twitter Snowflake identifier generator. | ||
| import time | ||
|
|
||
| Snowflake produces roughly time-ordered 64-bit integer identifiers without | ||
| coordination between nodes. Each identifier packs the milliseconds elapsed | ||
| since a custom epoch, a node identifier and a per-millisecond sequence counter | ||
| into a single 63-bit positive integer (see ``constants`` for the layout). | ||
|
|
||
| The public entry point is :func:`generate_snowflake_id`. It is stateless: the | ||
| caller passes the sequence counter on every call and is responsible for | ||
| advancing it within a millisecond and resetting it when the clock ticks over. | ||
|
|
||
| Each packed field can be read back on its own with :func:`decode_timestamp_ms`, | ||
| :func:`decode_node_id` and :func:`decode_sequence_id`. | ||
| """ | ||
|
|
||
| import time # noqa: F401 | ||
|
|
||
| from .constants import ( # noqa: F401 | ||
| from .constants import ( | ||
| EPOCH_MS_DEFAULT, | ||
| NODE_ID_DEFAULT, | ||
| NODE_ID_MAX, | ||
|
|
@@ -25,90 +10,44 @@ | |
|
|
||
|
|
||
| def read_current_millis(epoch_ms: int) -> int: | ||
| """Read the number of milliseconds elapsed since the custom epoch. | ||
|
|
||
| Args: | ||
| epoch_ms: The custom epoch expressed as Unix milliseconds. | ||
| a = int(time.time() * 1000) | ||
|
|
||
| Returns: | ||
| The count of whole milliseconds between ``epoch_ms`` and now. May be | ||
| negative if ``epoch_ms`` lies in the future. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| return a - epoch_ms | ||
|
|
||
|
|
||
| def decode_timestamp_ms(snowflake_id: int, epoch_ms: int = EPOCH_MS_DEFAULT) -> int: | ||
| """Read the timestamp field out of a Snowflake identifier. | ||
|
|
||
| Args: | ||
| snowflake_id: An identifier produced against the same epoch. | ||
| epoch_ms: The epoch the identifier was generated against. Defaults to | ||
| the original Twitter epoch (2010-11-04 01:42:54.657 UTC). | ||
| a = snowflake_id >> 22 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Минус 1 балл за использование магических констант |
||
|
|
||
| Returns: | ||
| The absolute Unix time in milliseconds at which the identifier was | ||
| generated. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| return a + epoch_ms | ||
|
|
||
|
|
||
| def decode_node_id(snowflake_id: int) -> int: | ||
| """Read the node identifier field out of a Snowflake identifier. | ||
| a = (snowflake_id >> 12) & 0b1111111111 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| Args: | ||
| snowflake_id: An identifier produced by :func:`generate_snowflake_id`. | ||
|
|
||
| Returns: | ||
| The node identifier packed into ``snowflake_id``, in the range | ||
| ``[0, NODE_ID_MAX]``. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| return a | ||
|
|
||
|
|
||
| def decode_sequence_id(snowflake_id: int) -> int: | ||
| """Read the sequence counter field out of a Snowflake identifier. | ||
|
|
||
| Args: | ||
| snowflake_id: An identifier produced by :func:`generate_snowflake_id`. | ||
| a = snowflake_id & 0b111111111111 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| Returns: | ||
| The per-millisecond sequence counter packed into ``snowflake_id``, in | ||
| the range ``[0, SEQUENCE_ID_MAX]``. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| return a | ||
|
|
||
|
|
||
| def generate_snowflake_id( | ||
| sequence_id: int, | ||
| node_id: int = NODE_ID_DEFAULT, | ||
| epoch_ms: int = EPOCH_MS_DEFAULT, | ||
| ) -> int | None: | ||
| """Build and return a Snowflake identifier for the current millisecond. | ||
|
|
||
| The function is stateless: the caller passes the per-millisecond sequence | ||
| counter explicitly. It is the caller's responsibility to increment | ||
| ``sequence_id`` for identifiers minted within the same millisecond and to | ||
| reset it once the clock advances. | ||
|
|
||
| Args: | ||
| sequence_id: The per-millisecond sequence counter, in the range | ||
| ``[0, SEQUENCE_ID_MAX]``. | ||
| node_id: The identifier of this node, in the range ``[0, NODE_ID_MAX]``. | ||
| Optional; defaults to ``NODE_ID_DEFAULT``. | ||
| epoch_ms: The start of the epoch as Unix milliseconds. Optional; | ||
| defaults to the original Twitter epoch (2010-11-04 01:42:54.657 | ||
| UTC). | ||
|
|
||
| Returns: | ||
| The Snowflake identifier as a positive 63-bit integer, or ``None`` if | ||
| ``node_id`` is outside ``[0, NODE_ID_MAX]``, ``sequence_id`` is outside | ||
| ``[0, SEQUENCE_ID_MAX]``, or the elapsed time no longer fits in the | ||
| timestamp field (roughly 69 years after ``epoch_ms``). In each of those | ||
| cases an explanatory message is printed to stdout first. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return 0 | ||
| if node_id > NODE_ID_MAX or node_id < 0: | ||
| m = f"node_id must be in [0,{NODE_ID_MAX}]" | ||
| print(m) | ||
| return None | ||
| if sequence_id > SEQUENCE_ID_MAX or sequence_id < 0: | ||
| m = f"sequence_id must be in [0,{SEQUENCE_ID_MAX}]" | ||
| print(m) | ||
| return None | ||
| if epoch_ms > TIMESTAMP_MS_MAX and epoch_ms < 0: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Корректнее проверять не |
||
| m = "overflows" | ||
| print(m) | ||
| return None | ||
| return read_current_millis(epoch_ms) << 22 | node_id << 12 | sequence_id | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Неинформативное имя переменной. Невозможно понять, какой физический смысл заложен в переменную с именем
a. От этого код тяжелее читать.Минус 0.5 балла