Repository navigation
3. Чувашов Лев Юрьевич. 613 - #42
Closed
LeoChooAvia wants to merge 21 commits into
Closed
LeoChooAvia wants to merge 21 commits into
LeoChooAvia wants to merge 21 commits into
Conversation
Avshugan
reviewed
Oct 18, 2026
| # TODO: реализуйте функцию | ||
| return 0 | ||
|
|
||
| timestamp_ms = (snowflake_id >> 22) & (2**TIMESTAMP_BITS - 1) |
Collaborator
There was a problem hiding this comment.
Магические константы усложняют понимание кода.
Пункт S3, минус балл.
Avshugan
reviewed
Oct 21, 2026
| return (product_id, 0) | ||
|
|
||
|
|
||
| def find_cart_line(cart: list[CartLine], product_id: int) -> bool: |
Collaborator
There was a problem hiding this comment.
Тут можно было просто
return read_cart_line(...) is not NoneПункт S1
| if not storage: | ||
| return PRODUCT_ID_MIN | ||
|
|
||
| indexes = [i[PRODUCT_ID_INDEX] for i in storage] |
Collaborator
There was a problem hiding this comment.
Название для переменной i обычно используется для индекса, так что тут оно сбивает с толку при первом прочтении.
Пункт M2
Avshugan
reviewed
Oct 22, 2026
| for product in storage: | ||
| row = "|" | ||
| for i in range(len(TABLE_HEADERS)): | ||
| row += ( |
Collaborator
There was a problem hiding this comment.
Можно было использовать f строки и было проще.
Пункт T8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.