Repository navigation
Conversation
WWWVovan
changed the title
WWWVovan
changed the title
Avshugan
reviewed
Oct 18, 2026
| return None | ||
|
|
||
| snowflake_id = ( | ||
| (timestamp_ms << (NODE_ID_BITS + SEQUENCE_ID_BITS)) |
Collaborator
There was a problem hiding this comment.
Вычисление сдвига дублировано в функции decode_timestamp_ms. Это может быть опасно, так как если логика поменяется, то надо будет исправлять в 2х местах, а это можно забыть, поэтому лучше было вынести вычисление в отдельную константу.
Пункт S1, минус балл.
Avshugan
reviewed
Oct 21, 2026
|
|
||
| def read_product(storage: list[Product], product_id: int) -> Product | None: | ||
|
|
||
| for product in storage: |
Collaborator
There was a problem hiding this comment.
Цикл:
for index, product in enumerate(storage):
if product[PRODUCT_ID_INDEX] == product_id:встречается несколько раз, лучше было бы использовать везде read_product. Код был бы понятнее.
Пункт S1
Avshugan
reviewed
Oct 22, 2026
| match commands: | ||
| case ["help"]: | ||
| show_help() | ||
| return True |
Collaborator
There was a problem hiding this comment.
Думаю можно было бы вынести return True в конец функции, код был бы чище
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.