Repository navigation
Conversation
Avshugan
reviewed
Oct 22, 2026
|
|
||
| from .crud import read_product, update_product # noqa: F401 | ||
| from .storage import ( # noqa: F401 | ||
| from crud import read_product, update_product |
| """ | ||
| # TODO: реализуйте функцию | ||
| return (0, 0) | ||
| prod = read_product(storage, product_id) |
Collaborator
There was a problem hiding this comment.
Лучше не экономить строки и оставлять пробелы (пустые строки) между логическими блоками. Так читабельность кода улучшается.
Avshugan
reviewed
Oct 22, 2026
| # TODO: реализуйте функцию | ||
| return (0, "", Decimal(0), 0) | ||
| for i in range(len(storage)): | ||
| if storage[i][PRODUCT_ID_INDEX] is product_id: |
Collaborator
There was a problem hiding this comment.
Если значения id у вас будут большими, то is уже не будет проходить, так как is сравнивает, что объект один и тот же, а не равен
| # TODO: реализуйте функцию | ||
| return (0, "", Decimal(0), 0) | ||
| for i in range(len(storage)): | ||
| if storage[i][PRODUCT_ID_INDEX] is product_id: |
Collaborator
There was a problem hiding this comment.
Этот цикл встречается несколько раз, лучше было бы поиск вынести в отдельную функцию.
Пункт S1
Avshugan
reviewed
Oct 22, 2026
| from decimal import Decimal | ||
|
|
||
| from .storage import ( # noqa: F401 | ||
| from storage import ( |
| # TODO: реализуйте функцию | ||
| return 0 | ||
| def create_product(storage: list[Product], fields: tuple[str, Decimal, int]) -> int | None: | ||
| fields = (normalize_product_name(fields[0]), fields[1], fields[2]) |
Collaborator
There was a problem hiding this comment.
Магические константы
Пункт S3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.