Repository navigation
1. Банад Михаил Вячеславович. 614 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d7c88f3
86c89c4
7bab989
c552b88
1e23410
3a6dc3d
edd79d8
2c1f76f
d173d13
d656349
ff338aa
bf59011
66427ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,10 @@ | ||
| """Bit layout and default epoch for the Twitter Snowflake ID generator. | ||
|
|
||
| A Snowflake identifier is a 63-bit positive integer packed as follows, from | ||
| the most significant bit downwards: | ||
|
|
||
| 1 bit unused sign bit, always zero | ||
| 41 bits milliseconds elapsed since a custom epoch | ||
| 10 bits node identifier | ||
| 12 bits per-millisecond sequence counter | ||
|
|
||
| The shift and mask constants should be derived from the bit widths so that | ||
| changing a width keeps everything else consistent. | ||
| """ | ||
|
|
||
| from typing import Final | ||
|
|
||
|
|
||
| # TODO: замените заглушки (0) на корректные значения, см. TASK.md. | ||
| # Все константы, зависящие от ёмкостей *_BITS, должны вычисляться из них. | ||
|
|
||
| # Twitter's original Snowflake epoch: 2010-11-04 01:42:54.657 UTC. | ||
| EPOCH_MS_DEFAULT: Final[int] = 0 | ||
|
|
||
| # Node identifier used when the caller does not supply one. | ||
| NODE_ID_DEFAULT: Final[int] = 0 | ||
|
|
||
| # Width of each field, in bits. | ||
| TIMESTAMP_BITS: Final[int] = 0 | ||
| NODE_ID_BITS: Final[int] = 0 | ||
| SEQUENCE_ID_BITS: Final[int] = 0 | ||
|
|
||
| # Largest value each field can hold. | ||
| TIMESTAMP_MS_MAX: Final[int] = 0 | ||
| NODE_ID_MAX: Final[int] = 0 | ||
| SEQUENCE_ID_MAX: Final[int] = 0 | ||
|
|
||
| # Здесь можно добавить собственные вспомогательные константы | ||
| # (например, сдвиги полей при сборке идентификатора). | ||
| EPOCH_MS_DEFAULT: int = 1288834974657 | ||
| NODE_ID_DEFAULT: int = 1 | ||
| TIMESTAMP_BITS: int = 41 | ||
| NODE_ID_BITS: int = 10 | ||
| SEQUENCE_ID_BITS: int = 12 | ||
| TIMESTAMP_MS_MAX: int = 2**TIMESTAMP_BITS - 1 | ||
| NODE_ID_MAX: int = 2**NODE_ID_BITS - 1 | ||
| SEQUENCE_ID_MAX: int = 2**SEQUENCE_ID_BITS - 1 | ||
| NODE_ID_SHIFT: int = SEQUENCE_ID_BITS | ||
| TIMESTAMP_SHIFT: int = SEQUENCE_ID_BITS + NODE_ID_BITS | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,114 +1,52 @@ | ||||||
| """Twitter Snowflake identifier generator. | ||||||
| import time | ||||||
|
|
||||||
| Snowflake produces roughly time-ordered 64-bit integer identifiers without | ||||||
| coordination between nodes. Each identifier packs the milliseconds elapsed | ||||||
| since a custom epoch, a node identifier and a per-millisecond sequence counter | ||||||
| into a single 63-bit positive integer (see ``constants`` for the layout). | ||||||
|
|
||||||
| The public entry point is :func:`generate_snowflake_id`. It is stateless: the | ||||||
| caller passes the sequence counter on every call and is responsible for | ||||||
| advancing it within a millisecond and resetting it when the clock ticks over. | ||||||
|
|
||||||
| Each packed field can be read back on its own with :func:`decode_timestamp_ms`, | ||||||
| :func:`decode_node_id` and :func:`decode_sequence_id`. | ||||||
| """ | ||||||
|
|
||||||
| import time # noqa: F401 | ||||||
|
|
||||||
| from .constants import ( # noqa: F401 | ||||||
| from .constants import ( | ||||||
| EPOCH_MS_DEFAULT, | ||||||
| NODE_ID_DEFAULT, | ||||||
| NODE_ID_MAX, | ||||||
| NODE_ID_SHIFT, | ||||||
| SEQUENCE_ID_MAX, | ||||||
| TIMESTAMP_MS_MAX, | ||||||
| TIMESTAMP_SHIFT, | ||||||
| ) | ||||||
|
|
||||||
|
|
||||||
| def read_current_millis(epoch_ms: int) -> int: | ||||||
| """Read the number of milliseconds elapsed since the custom epoch. | ||||||
|
|
||||||
| Args: | ||||||
| epoch_ms: The custom epoch expressed as Unix milliseconds. | ||||||
|
|
||||||
| Returns: | ||||||
| The count of whole milliseconds between ``epoch_ms`` and now. May be | ||||||
| negative if ``epoch_ms`` lies in the future. | ||||||
| """ | ||||||
| # TODO: реализуйте функцию | ||||||
| return 0 | ||||||
| return int(int(time.time() * 1000) - epoch_ms) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Лишний
Suggested change
|
||||||
|
|
||||||
|
|
||||||
| def decode_timestamp_ms(snowflake_id: int, epoch_ms: int = EPOCH_MS_DEFAULT) -> int: | ||||||
| """Read the timestamp field out of a Snowflake identifier. | ||||||
|
|
||||||
| Args: | ||||||
| snowflake_id: An identifier produced against the same epoch. | ||||||
| epoch_ms: The epoch the identifier was generated against. Defaults to | ||||||
| the original Twitter epoch (2010-11-04 01:42:54.657 UTC). | ||||||
|
|
||||||
| Returns: | ||||||
| The absolute Unix time in milliseconds at which the identifier was | ||||||
| generated. | ||||||
| """ | ||||||
| # TODO: реализуйте функцию | ||||||
| return 0 | ||||||
| return int(snowflake_id // (2**TIMESTAMP_SHIFT) + epoch_ms) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Можно было бы реализовать это через битовые операции. Тогда не пришлось бы вызывать |
||||||
|
|
||||||
|
|
||||||
| def decode_node_id(snowflake_id: int) -> int: | ||||||
| """Read the node identifier field out of a Snowflake identifier. | ||||||
|
|
||||||
| Args: | ||||||
| snowflake_id: An identifier produced by :func:`generate_snowflake_id`. | ||||||
|
|
||||||
| Returns: | ||||||
| The node identifier packed into ``snowflake_id``, in the range | ||||||
| ``[0, NODE_ID_MAX]``. | ||||||
| """ | ||||||
| # TODO: реализуйте функцию | ||||||
| return 0 | ||||||
| def decode_node_id(snowflake_id: int, epoch_ms: int = EPOCH_MS_DEFAULT) -> int: | ||||||
| return int( | ||||||
| ( | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Очень длинная операция, на что указывает ее разбиение на несколько физических строк. Такой код тяжело читать и понимать. Лучше разбить его на несколько простых операций, записанных последовательно на разных физических строках. timestamp_shift_from_epoch = decode_timestamp_ms(snowflake_id, epoch_ms) - epoch_ms
id_without_timestamp = snowflake_id - (timestamp_shift_from_epoch * 2 ** TIMESTAMP_SHIFT)
node_id = id_without_timestamp // (2 ** NODE_ID_SHIFT)А так, реализация через битовые операции была бы гораздо проще и лаконичнее |
||||||
| snowflake_id | ||||||
| - ( | ||||||
| (decode_timestamp_ms(snowflake_id, epoch_ms) - epoch_ms) | ||||||
| * 2**TIMESTAMP_SHIFT | ||||||
| ) | ||||||
| ) | ||||||
| // (2**NODE_ID_SHIFT) | ||||||
| ) | ||||||
|
|
||||||
|
|
||||||
| def decode_sequence_id(snowflake_id: int) -> int: | ||||||
| """Read the sequence counter field out of a Snowflake identifier. | ||||||
|
|
||||||
| Args: | ||||||
| snowflake_id: An identifier produced by :func:`generate_snowflake_id`. | ||||||
|
|
||||||
| Returns: | ||||||
| The per-millisecond sequence counter packed into ``snowflake_id``, in | ||||||
| the range ``[0, SEQUENCE_ID_MAX]``. | ||||||
| """ | ||||||
| # TODO: реализуйте функцию | ||||||
| return 0 | ||||||
| return int(snowflake_id - ((snowflake_id // 2**NODE_ID_SHIFT) * (2**NODE_ID_SHIFT))) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Аналогично. Реализация через битовые операции была бы гораздо проще и не требовала бы вызова |
||||||
|
|
||||||
|
|
||||||
| def generate_snowflake_id( | ||||||
| sequence_id: int, | ||||||
| node_id: int = NODE_ID_DEFAULT, | ||||||
| epoch_ms: int = EPOCH_MS_DEFAULT, | ||||||
| sequence_id: int, node_id: int = NODE_ID_DEFAULT, epoch_ms: int = EPOCH_MS_DEFAULT | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Зачем изменили группировку параметров и переписали все на одной строке? Так сложнее читать код |
||||||
| ) -> int | None: | ||||||
| """Build and return a Snowflake identifier for the current millisecond. | ||||||
|
|
||||||
| The function is stateless: the caller passes the per-millisecond sequence | ||||||
| counter explicitly. It is the caller's responsibility to increment | ||||||
| ``sequence_id`` for identifiers minted within the same millisecond and to | ||||||
| reset it once the clock advances. | ||||||
|
|
||||||
| Args: | ||||||
| sequence_id: The per-millisecond sequence counter, in the range | ||||||
| ``[0, SEQUENCE_ID_MAX]``. | ||||||
| node_id: The identifier of this node, in the range ``[0, NODE_ID_MAX]``. | ||||||
| Optional; defaults to ``NODE_ID_DEFAULT``. | ||||||
| epoch_ms: The start of the epoch as Unix milliseconds. Optional; | ||||||
| defaults to the original Twitter epoch (2010-11-04 01:42:54.657 | ||||||
| UTC). | ||||||
|
|
||||||
| Returns: | ||||||
| The Snowflake identifier as a positive 63-bit integer, or ``None`` if | ||||||
| ``node_id`` is outside ``[0, NODE_ID_MAX]``, ``sequence_id`` is outside | ||||||
| ``[0, SEQUENCE_ID_MAX]``, or the elapsed time no longer fits in the | ||||||
| timestamp field (roughly 69 years after ``epoch_ms``). In each of those | ||||||
| cases an explanatory message is printed to stdout first. | ||||||
| """ | ||||||
| # TODO: реализуйте функцию | ||||||
| return 0 | ||||||
| current_millis = read_current_millis(epoch_ms) | ||||||
| if current_millis < 0 or current_millis > TIMESTAMP_MS_MAX: | ||||||
| raise ValueError("Превышен максимальный лимит времени") | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
| if node_id < 0 or node_id > NODE_ID_MAX: | ||||||
| raise ValueError("Node Id выходит за допустимые пределы") | ||||||
| if sequence_id < 0 or sequence_id > SEQUENCE_ID_MAX: | ||||||
| raise ValueError("Sequence Id выходит за допустимые пределы") | ||||||
| return int( | ||||||
| (current_millis * (2**TIMESTAMP_SHIFT)) | ||||||
| + (node_id * (2**NODE_ID_SHIFT) + sequence_id) | ||||||
| ) | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А зачем удалили
typing.Finalиз аннотаций?