Repository navigation
2. Васильев Егор Евгеньевич. 613 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,10 @@ | ||
| """Shopping-cart operations layered on top of the product store. | ||
|
|
||
| The cart is a plain list of tuples, one :data:`CartLine` -- | ||
| ``(product_id, quantity)`` -- per distinct product. Moving units between the | ||
| store and the cart keeps the two sides in balance: :func:`add_to_cart` takes | ||
| units out of stock, :func:`remove_from_cart` puts them back. | ||
|
|
||
| Like the CRUD layer, the failure path never raises -- the operation prints | ||
| an explanatory message to stdout and returns ``None``. | ||
| """ | ||
|
|
||
| from typing import Final | ||
|
|
||
| from .crud import read_product, update_product # noqa: F401 | ||
| from .storage import ( # noqa: F401 | ||
| NAME_INDEX, | ||
| PRICE_INDEX, | ||
| PRODUCT_ID_INDEX, | ||
| QUANTITY_INDEX, | ||
| Product, | ||
| ) | ||
|
|
@@ -24,37 +14,65 @@ | |
|
|
||
| # TODO: задайте позиции полей внутри кортежа CartLine | ||
| LINE_PRODUCT_ID_INDEX: Final = 0 | ||
| LINE_QUANTITY_INDEX: Final = 0 | ||
| LINE_QUANTITY_INDEX: Final = 1 | ||
|
|
||
|
|
||
| def add_to_cart( | ||
| storage: list[Product], | ||
| def change_cart_quantity( | ||
| cart: list[CartLine], | ||
| product_id: int, | ||
| quantity: int, | ||
| ) -> CartLine | None: | ||
| """Move ``quantity`` units of ``product_id`` from the store into ``cart``. | ||
| for i, cart_i in enumerate(cart): | ||
| if cart_i[LINE_PRODUCT_ID_INDEX] == product_id: | ||
| if cart_i[LINE_QUANTITY_INDEX] + quantity == 0: | ||
| del cart[i] | ||
| return (product_id, 0) | ||
| cart[i] = (cart_i[0], cart_i[1] + quantity) | ||
| return cart[i] | ||
| return None | ||
|
|
||
| The product is looked up in ``storage``. If it is missing, a message is | ||
| printed (by :func:`~src.part2.crud.read_product`) and nothing | ||
| changes. If the store holds fewer units than requested, an explanatory | ||
| message is printed and nothing changes. Otherwise the store record is | ||
| decremented by ``quantity`` and the cart line for ``product_id`` gains | ||
| ``quantity`` units -- a new line is created when the cart had none. | ||
|
|
||
| Args: | ||
| storage: The product store to draw stock from; modified in place on | ||
| success. | ||
| cart: The cart to add the units to; modified in place on success. | ||
| product_id: The identifier of the product to add. | ||
| quantity: Number of units to move into the cart. | ||
|
|
||
| Returns: | ||
| The cart line for ``product_id`` after the addition, or ``None`` | ||
| when the product is unknown or the store cannot cover the request. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return (0, 0) | ||
| def add_to_cart( | ||
| storage: list[Product], | ||
| cart: list[CartLine], | ||
| product_id: int, | ||
| quantity: int, | ||
| ) -> CartLine | None: | ||
| product_new = read_product(storage, product_id) | ||
| if product_new is None: | ||
| return None | ||
| if product_new[QUANTITY_INDEX] < quantity: | ||
| print( | ||
| f"not enough stock for product {product_id}: {product_new[QUANTITY_INDEX]} available, {quantity} requested" | ||
| ) | ||
| return None | ||
| index = next( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Надо было использовать функции из crud.py, а то в результате получилась копипаста. |
||
| (i for i, p in enumerate(storage) if p[PRODUCT_ID_INDEX] == product_id), None | ||
| ) | ||
| if index is None: | ||
| return None | ||
| storage[index] = ( | ||
| product_new[0], | ||
| product_new[1], | ||
| product_new[2], | ||
| product_new[3] - quantity, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Магические константы (для которых даже константы есть) |
||
| ) | ||
| change = change_cart_quantity(cart, product_id, quantity) | ||
| if change is None: | ||
| cart.append((product_id, quantity)) | ||
| return (product_id, quantity) | ||
| else: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Пункт Т1 |
||
| return change | ||
|
|
||
|
|
||
| def find_cart_line( | ||
| cart: list[CartLine], | ||
| product_id: int, | ||
| ) -> CartLine | None: | ||
| for cart_i in cart: | ||
| if cart_i[LINE_PRODUCT_ID_INDEX] == product_id: | ||
| return cart_i | ||
| return None | ||
|
|
||
|
|
||
| def remove_from_cart( | ||
|
|
@@ -63,27 +81,27 @@ def remove_from_cart( | |
| product_id: int, | ||
| quantity: int, | ||
| ) -> CartLine | None: | ||
| """Move ``quantity`` units of ``product_id`` from ``cart`` back to the store. | ||
|
|
||
| The cart line for ``product_id`` is looked up. If there is none, a | ||
| message is printed and nothing changes. If the line holds fewer units | ||
| than requested, an explanatory message is printed and nothing changes. | ||
| Otherwise the cart line loses ``quantity`` units -- the line is dropped | ||
| when it reaches zero -- and the store record gains ``quantity`` units | ||
| back. | ||
|
|
||
| Args: | ||
| storage: The product store to return stock to; modified in place on | ||
| success. | ||
| cart: The cart to take the units from; modified in place on | ||
| success. | ||
| product_id: The identifier of the product to remove. | ||
| quantity: Number of units to move back into the store. | ||
|
|
||
| Returns: | ||
| The cart line for ``product_id`` after the removal (a quantity of | ||
| zero means the line was dropped), or ``None`` when the cart has no | ||
| line for the product or holds too few units. | ||
| """ | ||
| # TODO: реализуйте функцию | ||
| return (0, 0) | ||
| cart_find = find_cart_line(cart, product_id) | ||
| if cart_find is None: | ||
| print(f"product {product_id} is not in the cart") | ||
| return None | ||
| if cart_find[LINE_QUANTITY_INDEX] < quantity: | ||
| print( | ||
| f"cart holds only {cart_find[LINE_QUANTITY_INDEX]} unit(s) of product {product_id}, cannot remove {quantity}" | ||
| ) | ||
| return None | ||
| product_new = read_product(storage, product_id) | ||
| if product_new == None: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Пункт T3 |
||
| return None | ||
| index = next( | ||
| (i for i, p in enumerate(storage) if p[PRODUCT_ID_INDEX] == product_id), None | ||
| ) | ||
| if index is None: | ||
| return None | ||
| storage[index] = ( | ||
| product_new[0], | ||
| product_new[1], | ||
| product_new[2], | ||
| product_new[3] + quantity, | ||
| ) | ||
| return change_cart_quantity(cart, product_id, -quantity) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лучше не экономить строки и оставлять пробелы (пустые строки) между логическими блоками. Так читабельность кода улучшается.