Repository navigation
Conversation
| if product is None: | ||
| return None | ||
|
|
||
| for i in range(len(storage)): |
Member
There was a problem hiding this comment.
Нарушение критерия T5. Минус 0.25 балла
| return None | ||
|
|
||
| for i in range(len(storage)): | ||
| product = storage[i] |
Member
There was a problem hiding this comment.
В этом цикле очень много лишних в цикле. Часть операций можно вынести за пределы цикла, тогда код будет читаться легче.
|
|
||
| name, price = product[NAME_INDEX], product[PRICE_INDEX] | ||
| new_product = (product_id, name, price, quantity_storage - quantity) | ||
| storage[i] = new_product |
Member
There was a problem hiding this comment.
Это, фактически, дублирование логики функции апдейта хранилища из crud.py. Нарушение критерия S1. Минус балл
Вместо копипасты следовало вызвать уже реализованную в crud.py функцию для обновления состояния хранилища.
|
|
||
| def generate_product_id(storage: list[Product]) -> int: | ||
| """Choose the identifier for the next product added to ``storage``. | ||
| if len(storage) == 0: |
Member
There was a problem hiding this comment.
Нарушение критерия T4. Минус 0.25 балла
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.