gh-91484: Allow memoryview cast for F-contiguous#137803
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
StanFromIreland
left a comment
There was a problem hiding this comment.
This change needs a NEWS entry, you can do it via the web interface (comment above) or with the blurb tool locally. You also have some trailing whitespace.
|
@corona10 Please check my Pull Request |
|
@StanFromIreland thank you! I added NEWS entry. |
corona10
left a comment
There was a problem hiding this comment.
Please check lint status, looks like there is empty space in some line.
|
Ok, I removed the trailing whitespace. |
|
This PR is stale because it has been open for 30 days with no activity. |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Looks fine. I added some minor suggestions, and please update Doc/library/stdtypes.rst which says "Supported casts are 1D -> C-:term:contiguous and C-contiguous -> 1D." Mention that an F-contiguous can also be cast to 1D. Add versionchanged:: next and a What's New entry.
I just submitted a complementary PR #153663. They can be merged in arbitrary order, but the latter will need to resolve conflict in What's New.
Documentation build overview
|
|
Thanks for the review! I applied the suggestions and updated the docs, NEWS, and What's New entry. Please let me know if I missed anything. |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
Thank you for your contribution!
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, thanks! All review points addressed.
Note for whoever merges second (this or #153663): there will be a trivial What's New conflict in Doc/whatsnew/3.16.rst since both add to "Other language changes".
Allow N-D to 1-D memoryview cast for F-contiguous
memoryviews incast#91484