gh-148665: Enable socket.shutdown function for emscripten

[ryanking13]

Fixes #148665

Enables socket.shutdown method for emscripten

• Issue: Enable socket.shutdown function for emscripten builds #148665

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[picnixz]

I am sorry but this would be a breaking change. So I prefer that we first reach a consensus (which is the usual process).

[ryanking13]

I am sorry but this would be a breaking change. So I prefer that we first reach a consensus (which is the usual process).

Sure. I totally agree with that point.

[freakboy3742]

@picnixz I'm not sure I follow why would this be a breaking change. Nobody will be using socket.shutdown on Emscripten at present, because it will be raising an exception (OSError?); and as far as I can tell, the internal uses inside the Python standard library (such as TCPServer.shutdown_request() are catching the OSError and making it a no-op; th

What's the concern here about a breaking change? Is there a detail I'm missing?

[picnixz]

The breaking change was about the hasattr checks and exception catching. It may be a non-issue but this should be taken into account (see issue). I closed the PR because we usually first discuss such changes before a PR.

If you believe this would not be an issue then it is fine as well but we need to convene the change more loudly (in terms of docs). I just did not want a PR sitting there without a clear "yes" on the issue.

[picnixz]

Considering #148665 (comment), I'm reopening the PR. I'll let @hoodmane shepherd this then.

[read-the-docs-community]

Documentation build overview

📚 cpython-previews | 🛠️ Build #33654435 | 📁 Comparing 196c852 against main (1604043)

  🔍 Preview build  

283 files changed · + 1 added · ± 273 modified · - 9 deleted

+ Added

• library/asyncio-policy.html

± Modified

• bugs.html
• glossary.html
• index.html
• py-modindex.html
• c-api/allocation.html
• c-api/buffer.html
• c-api/bytes.html
• c-api/code.html
• c-api/complex.html
• c-api/concrete.html
• and 263 more...

- Deleted

• c-api/sentinel.html
• c-api/slots.html
• deprecations/pending-removal-in-3.21.html
• howto/abi3t-migration.html
• library/asyncio-threading.html
• library/asyncio-tools.html
• library/tkinter.fontchooser.html
• library/tkinter.systray.html
• whatsnew/3.16.html

[freakboy3742]

👍

[miss-islington-app]

Thanks @ryanking13 for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

[bedevere-app]

GH-154319 is a backport of this pull request to the 3.15 branch.