Skip to content

gh-152068: Reset PyREPL Colors on prompt finish#152108

Merged
pablogsal merged 9 commits into
python:mainfrom
edvilme:gh-152068-pyrepl-color-bug
Jul 4, 2026
Merged

gh-152068: Reset PyREPL Colors on prompt finish#152108
pablogsal merged 9 commits into
python:mainfrom
edvilme:gh-152068-pyrepl-color-bug

Conversation

@edvilme

@edvilme edvilme commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes a bug when a line was split (particularly on macOS Terminal.app) in the middle of a colorized keyword, causing the ANSI Color Reset sequence (\x1b[0m) to not be properly printed, causing the output to be colored when it shouldn't.

Before and after

Screenshot 2026-06-24 at 7 57 42 p m

CC @StanFromIreland

@bedevere-app bedevere-app Bot mentioned this pull request Jun 24, 2026
Open
@brettcannon
brettcannon self-requested a review July 1, 2026 02:43
pablogsal
pablogsal reviewed Jul 2, 2026
View reviewed changes
Comment thread Lib/_pyrepl/unix_console.py
Comment thread Misc/NEWS.d/next/macOS/2026-06-24-18-00-39.gh-issue-152068.ThsmJU.rst
Comment thread Misc/NEWS.d/next/macOS/2026-06-24-18-00-39.gh-issue-152068.ThsmJU.rst
Comment thread Misc/NEWS.d/next/macOS/2026-06-24-18-00-39.gh-issue-152068.ThsmJU.rst
edvilme and others added 2 commits July 2, 2026 10:48
@edvilme @pablogsal
Update Misc/NEWS.d/next/macOS/2026-06-24-18-00-39.gh-issue-152068.Ths…
3a86dff 
…mJU.rst

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@edvilme
Remove news entry
e69cf97
@edvilme
edvilme force-pushed the gh-152068-pyrepl-color-bug branch from 0c56e5d to d54cfb8 Compare July 2, 2026 19:23
@edvilme
edvilme requested a review from terryjreedy as a code owner July 2, 2026 19:23
@edvilme
edvilme force-pushed the gh-152068-pyrepl-color-bug branch from d54cfb8 to 529de59 Compare July 2, 2026 19:24
@edvilme
pythongh-152068: Test ANSI reset is emitted on console finish() and r…
e4d0eb2 
…estore()

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme
edvilme requested a review from pablogsal July 2, 2026 20:42
pablogsal
pablogsal approved these changes Jul 4, 2026
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the PR!

@pablogsal pablogsal added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 4, 2026
@pablogsal
pablogsal merged commit 832d557 into python:main Jul 4, 2026
72 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 4, 2026

Copy link
Copy Markdown

Thanks @edvilme for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 4, 2026

Copy link
Copy Markdown

Sorry, @edvilme and @pablogsal, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 832d5571115fba0adcb09742b56f51ee081710c6 3.14

@bedevere-app

bedevere-app Bot commented Jul 4, 2026

Copy link
Copy Markdown

GH-153029 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 4, 2026
pablogsal pushed a commit that referenced this pull request Jul 4, 2026
@miss-islington
[3.15] gh-152068: Reset PyREPL Colors on prompt finish (GH-152108) (#…
cb0adb0 
…153029)
@StanFromIreland

StanFromIreland commented Jul 6, 2026

Copy link
Copy Markdown
Member

@edvilme can you please do the backport?

@edvilme

edvilme commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@edvilme can you please do the backport?

Yes. I am out for vacation currently but will do the backport as soon as I have some free time :)
It is for 3.15 right? Or should I do 3.14 too?

@StanFromIreland

StanFromIreland commented Jul 8, 2026

Copy link
Copy Markdown
Member

3.15 was done automatically, 3.14 is pending. See bot comments above.

@serhiy-storchaka

serhiy-storchaka commented Jul 15, 2026

Copy link
Copy Markdown
Member

Please don't forget about backports.

@edvilme

edvilme commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Hello. Yes, I am currently out of town and don't have access to my computer, but will create the PR later this week

@edvilme edvilme mentioned this pull request Jul 21, 2026
Open
@bedevere-app

bedevere-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

GH-154402 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 21, 2026
edvilme added a commit to edvilme/cpython that referenced this pull request Jul 21, 2026
@edvilme @blurb-it
@pablogsal
pythongh-152068: Reset PyREPL Colors on prompt finish (python#152108)
6264ad9 
* Use ANSI Escape Codes from Colorize

* Print ANSI Color reset on finish and restore

* 📜🤖 Added by blurb_it.

* Update imports

* Update Misc/NEWS.d/next/macOS/2026-06-24-18-00-39.gh-issue-152068.ThsmJU.rst

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

* Remove news entry

* 📜🤖 Added by blurb_it.

* pythongh-152068: Test ANSI reset is emitted on console finish() and restore()

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme

edvilme commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Manual rebase #154402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon
@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edvilme @StanFromIreland @serhiy-storchaka @pablogsal