Skip to content

gh-153133: Fix socket leak in asyncio create_connection#153134

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
deadlovelll:gh-153133-socket-leak
Jul 7, 2026
Merged

gh-153133: Fix socket leak in asyncio create_connection#153134
kumaraditya303 merged 2 commits into
python:mainfrom
deadlovelll:gh-153133-socket-leak

Conversation

@deadlovelll

@deadlovelll deadlovelll commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Close the socket in _create_connection_transport() when the transport is never created, not only on await failure

For more details see gh-153133

@bedevere-app bedevere-app Bot mentioned this pull request Jul 5, 2026
Closed
kumaraditya303
kumaraditya303 reviewed Jul 7, 2026
View reviewed changes
Comment thread Lib/asyncio/base_events.py Outdated
@kumaraditya303
kumaraditya303 merged commit 374920a into python:main Jul 7, 2026
55 checks passed
@kumaraditya303 kumaraditya303 added topic-asyncio needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 24, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @deadlovelll for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @deadlovelll for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Sorry, @deadlovelll and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 374920a23d49130f446fe6369220bc548be57cd2 3.14

@bedevere-app

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154631 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 24, 2026
kumaraditya303 pushed a commit that referenced this pull request Jul 25, 2026
@miss-islington @deadlovelll
[3.15] gh-153133: Fix socket leak in error path of asyncio create_con…
b4d0b26 
…nection (GH-153134) (#154631)

gh-153133: Fix socket leak in error path of asyncio create_connection (GH-153134)
(cherry picked from commit 374920a)

Co-authored-by: Timofei <128279579+deadlovelll@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels

needs backport to 3.14 bugs and security fixes topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deadlovelll @kumaraditya303