Skip to content

gh-153511: Removes Tools/msi, Tools/nuget, and legacy py.exe launcher sources#153512

Merged
zooba merged 9 commits into
python:mainfrom
zooba:gh-153511
Jul 20, 2026
Merged

gh-153511: Removes Tools/msi, Tools/nuget, and legacy py.exe launcher sources#153512
zooba merged 9 commits into
python:mainfrom
zooba:gh-153511

Conversation

@zooba

@zooba zooba commented Jul 10, 2026

Copy link
Copy Markdown
Member

@zooba

zooba commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

For anyone actually reviewing this, the PC/layout/README.md file is an addition, not a removal, but it's hard to find in the diff view. Initial contents are here but that link won't update with new commits.

@hugovk

hugovk commented Jul 10, 2026

Copy link
Copy Markdown
Member

A bunch of suggestions from Claude:


Orphaned build files (clear removals)

  • PCbuild/pyshellext.vcxproj and PCbuild/pyshellext.vcxproj.filters — the sources
    (PC/pyshellext.cpp/.def/.rc) were deleted and the project was already dropped from
    pcbuild.sln/pcbuild.proj, so these two files are dead.
  • PCbuild/venvlauncher.vcxproj.filters:17 and PCbuild/venvwlauncher.vcxproj.filters:22
    still reference the deleted ..\PC\pylauncher.rc; the .vcxproj files were updated to
    python_exe.rc, but the .filters weren't.

References to deleted files

  • README.rst:79-80 — links to the deleted Tools/msi/README.txt ("To build Windows
    installer, see …").
  • PC/store_info.txt:30,46 — instructions call the deleted Tools/msi/make_appx.ps1.
  • .github/CODEOWNERS:192-193,196 — entries for Tools/msi/, Tools/nuget/, and
    PC/launcher.c.
  • .gitignore:53,161Tools/msi/obj and the "not Tools/msi/core" comment.
  • .gitattributes:22PC/classicAppCompat.* binary (the files are gone; appxmanifest.py
    deliberately keeps runtime logic for older releases, but the attribute is dead).
  • PCbuild/readme.txt:143-160 — still documents the pylauncher, pywlauncher, and
    pyshellext sub-projects.

Dead CI/tooling logic

  • Tools/build/compute-changes.py — the whole run_windows_msi path (lines 120, 163-164,
    226, 248-250, 291-293, 330, 345) triggers on the deleted reusable-windows-msi.yml and
    Tools/msi/; build.yml/reusable-context.yml no longer consume it. The matching test data
    in Lib/test/test_tools/test_compute_changes.py:114-115 too.
  • .azure-pipelines/windows-layout-steps.yml:15-i test_launcher excludes a test that no
    longer exists.

Stale doc/comment pointers to PC/launcher.c

  • Include/internal/pycore_magic_number.h:314 — "PC/launcher.c must also be updated"
    (magic-number bump instructions).
  • InternalDocs/interpreter.md:312 — same note, with a link to the deleted file. These
    presumably should now point at the launcher's new home (pymanager) or be dropped.

@zooba

zooba commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

Thanks, Claude (I wish we hadn't turned off Copilot reviews here, at least those would come with suggestions that I could batch and commit from the UI...)

@zooba
zooba marked this pull request as ready for review July 10, 2026 13:35
@hugovk

hugovk commented Jul 10, 2026

Copy link
Copy Markdown
Member

Also a couple of docs sections that could be removed; or possibly just keep the red "Deprecated since version 3.14" paragraph, change the tense, and update deprecated:: 3.14 to deprecated-removed:: 3.14 3.16:

@read-the-docs-community

read-the-docs-community Bot commented Jul 14, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33589214 | 📁 Comparing aceaeda against main (d807210)

  🔍 Preview build  

6 files changed · ± 6 modified

± Modified

@zooba
zooba requested a review from StanFromIreland as a code owner July 14, 2026 20:45
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2026
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit aceaeda 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F153512%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2026
@zooba

zooba commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

The RHEL8 failures look like a curses issue, and the macOS one is clearly not caused by this change. I expect the others to be consistent, and all the likely impacted ones are already clean.

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@zooba
zooba merged commit bd31583 into python:main Jul 20, 2026
147 of 166 checks passed
@zooba
zooba deleted the gh-153511 branch July 20, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants