Skip to content

gh-154395: Skip test_environment_is_not_modified without rl_change_environment#154396

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:readline-change-environment
Jul 22, 2026
Merged

gh-154395: Skip test_environment_is_not_modified without rl_change_environment#154396
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:readline-change-environment

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 21, 2026

Copy link
Copy Markdown
Member

rl_change_environment only exists since readline 6.3. Without it readline sets LINES and COLUMNS, and there is nothing we can do about it.

…nge_environment

readline sets LINES and COLUMNS if rl_change_environment is not
available, which is the case with readline older than 6.3.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jul 21, 2026
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news labels Jul 21, 2026
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) July 21, 2026 18:11
@serhiy-storchaka
serhiy-storchaka merged commit 0e4940f into python:main Jul 22, 2026
97 of 99 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0e4940f0c113d8f4522ca3c120e470e9da922a8d 3.15

@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0e4940f0c113d8f4522ca3c120e470e9da922a8d 3.14

@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0e4940f0c113d8f4522ca3c120e470e9da922a8d 3.13

@serhiy-storchaka serhiy-storchaka removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant