-
-
Notifications
You must be signed in to change notification settings - Fork 35k
[3.14] gh-152068: Reset PyREPL Colors on prompt finish (#152108) #154402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edvilme
wants to merge
1
commit into
python:3.14
Choose a base branch
from
edvilme:backport-gh-152068-pyrepl-color-bug
base: 3.14
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,8 @@ | |
| import threading | ||
| import unittest | ||
| from functools import partial | ||
| from test.support import os_helper, force_not_colorized_test_class | ||
| from _colorize import ANSIColors | ||
| from test.support import force_color, os_helper, force_not_colorized_test_class | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you import |
||
| from test.support import threading_helper | ||
|
|
||
| from unittest import TestCase | ||
|
|
@@ -107,6 +108,24 @@ def test_no_newline(self, _os_write): | |
| self.assertNotIn(call(ANY, b'\n'), _os_write.mock_calls) | ||
| con.restore() | ||
|
|
||
| def test_reset_on_finish(self, _os_write): | ||
| # gh-152068: finish() must emit the ANSI reset sequence so any | ||
| # active color does not leak past the prompt. | ||
| code = "1" | ||
| events = code_to_events(code) | ||
| _, con = handle_events_unix_console(events) | ||
| con.finish() | ||
| _os_write.assert_any_call(ANY, ANSIColors.RESET.encode(con.encoding)) | ||
| con.restore() | ||
|
|
||
| def test_reset_on_restore(self, _os_write): | ||
| # gh-152068: restore() must emit the ANSI reset sequence. | ||
| code = "1" | ||
| events = code_to_events(code) | ||
| _, con = handle_events_unix_console(events) | ||
| con.restore() | ||
| _os_write.assert_any_call(ANY, ANSIColors.RESET.encode(con.encoding)) | ||
|
|
||
| def test_newline(self, _os_write): | ||
| code = "\n" | ||
| events = code_to_events(code) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |
|
|
||
|
|
||
| import itertools | ||
| from _colorize import ANSIColors | ||
| from functools import partial | ||
| from test.support import force_not_colorized_test_class | ||
| from typing import Iterable | ||
|
|
@@ -366,6 +367,28 @@ def test_multiline_ctrl_z(self): | |
| self.assertEqual(reader.cxy, (2, 3)) | ||
| con.restore() | ||
|
|
||
| def test_reset_on_finish(self): | ||
| # gh-152068: finish() must emit the ANSI reset sequence so any | ||
| # active color does not leak past the prompt. | ||
| code = "1" | ||
| events = code_to_events(code) | ||
| _, con = self.handle_events(events) | ||
| con.finish() | ||
| con.out.write.assert_any_call(ANSIColors.RESET.encode(con.encoding)) | ||
| con.restore() | ||
|
|
||
| def test_reset_on_restore(self): | ||
| # gh-152068: restore() must emit the ANSI reset sequence when VT | ||
| # support is enabled. | ||
| code = "1" | ||
| events = code_to_events(code) | ||
| _, con = self.handle_events(events) | ||
| con._WindowsConsole__vt_support = True | ||
| con._WindowsConsole__original_input_mode = 0 | ||
| with patch.object(wc, "SetConsoleMode", return_value=1): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| con.restore() | ||
| con.out.write.assert_any_call(ANSIColors.RESET.encode(con.encoding)) | ||
|
|
||
|
|
||
| class WindowsConsoleGetEventTests(TestCase): | ||
| # Virtual-Key Codes: https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes | ||
|
|
||
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2026-07-02-19-21-15.gh-issue-152068.ThsmJU.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fixes a bug when a line was split (particularly on macOS Terminal.app) in the middle of a colorized keyword, causing the ANSI Color Reset sequence (ESC0m) to not be properly printed, causing the output to be colored when it shouldn't |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this.