gh-135683: Honor raiseExceptions when opening the file fails in FileHandler#154542
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-135683: Honor raiseExceptions when opening the file fails in FileHandler#154542serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
… FileHandler FileHandler and WatchedFileHandler opened the file outside the try block that reports errors via handleError(), so an error while opening the file was raised instead of being handled, ignoring raiseExceptions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Split the WatchedFileHandler case into a separate test skipped on Windows, where open log files are locked and the directory holding them cannot be removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileHandlerandWatchedFileHandleropened the file outside thetryblock that reports errors viahandleError(), so an error while opening the file was raised instead of being handled, ignoringraiseExceptions. The rotating handlers were not affected, asBaseRotatingHandler.emit()wraps the whole body.🤖 Generated with Claude Code