gh-154592: Fix test_peg_generator in non-UTF-8 locales with a non-ASCII work dir#154593
Merged
serhiy-storchaka merged 1 commit intoJul 24, 2026
Merged
Conversation
…on-ASCII work dir setUpClass created a venv in the regrtest working directory (whose name has a non-ASCII suffix) and ran a child printing sysconfig.get_path(). In a locale whose encoding cannot encode that character, the child failed to encode the path. Force UTF-8 for the child. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-154598 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-154602 is a backport of this pull request to the 3.14 branch. |
|
GH-154603 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setUpClasscreates a venv in the regrtest working directory — whose name has a non-ASCII suffix (os_helper.FS_NONASCII,æon Windows) — then runs a child printingsysconfig.get_path(). In a non-UTF-8 locale whose encoding cannot encode that character (e.g. cp932 or cp1251 on Windows), the child fails to encode the path. Force UTF-8 for the child.