Conversation
checkout v3 -> v7, setup-python v4 -> v7, upload-artifact v3 -> v7, setup-qemu v2 -> v4, rust-cache v1 -> v2. upload-artifact v3 is sunset, so wheel uploads fail on every run.
Author
|
Note: the workflow run on this PR is queued behind first-time-contributor approval ("action_required"). It needs a maintainer click to start; I did not and cannot approve it myself. |
Author
|
Sorry for the extra push. I missed the checkout reference in benchmarks.yml in the original branch; the branch now updates it too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the action versions in
.github/workflows/main.yml.Changes:
actions/checkout@v3->v7actions/setup-python@v4->v7actions/upload-artifact@v3->v7docker/setup-qemu-action@v2->v4Swatinem/rust-cache@v1->v2The upload-artifact bump is the important one: v3 was sunset in January 2025, so the wheel upload steps in the
testsandarm-wheelsjobs fail on every run.Two things I left alone on purpose:
actions-rs/toolchain@v1is archived, butdtolnay/rust-toolchainis not a drop-in replacement and I did not want to mix that into a version bump.ubuntu-20.04matrix entry is a retired runner image. That needs a maintainer call (20.04 pins the manylinux build environment), so it is unchanged here.Validation: YAML parse of the edited workflow passes. Inputs in use (
name,path,fetch-depth,python-version,key,platforms) all exist in the new majors; setup-python v7 only removedpip-install, which this workflow does not use.Scope:
.github/workflows/main.ymlonly.